Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unicodeit: init at 0.7.5 #341370

Merged
merged 5 commits into from
Sep 14, 2024
Merged

unicodeit: init at 0.7.5 #341370

merged 5 commits into from
Sep 14, 2024

Conversation

nbraud
Copy link
Contributor

@nbraud nbraud commented Sep 12, 2024

Description of changes

  • Packaged python3.pkgs.unicodeit
  • Patched it (and sent a PR upstream) to expose the CLI entrypoint as a regular executable
  • Added a pkgs/by-name entry for users who just want the CLI

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Wrote and built package tests
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nbraud
Copy link
Contributor Author

nbraud commented Sep 12, 2024

Result of nixpkgs-review pr 341370 run on aarch64-darwin 1

@nbraud
Copy link
Contributor Author

nbraud commented Sep 12, 2024

Result of nixpkgs-review pr 341370 run on x86_64-linux 1

@nbraud
Copy link
Contributor Author

nbraud commented Sep 12, 2024

That's odd, I'm not sure why nixpkgs-review didn't pick up on the new drvs, let's see whether @ofborg does

PS: Nevermind, it might be working as intended, only rebuilding drvs which changed... which doesn't include new ones.

@nbraud nbraud requested a review from mkg20001 September 12, 2024 17:31
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 12, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 13, 2024
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@natsukium natsukium merged commit e79f91f into NixOS:master Sep 14, 2024
25 of 26 checks passed
@nbraud nbraud deleted the pkgs/unicodeit branch September 14, 2024 13:14
@nbraud
Copy link
Contributor Author

nbraud commented Sep 14, 2024

@natsukium Sorry, I should have said something: since the PR included fixup! commits, I was planning on doing a no-diff rebase prior to merging. It's no big issue though, don't worry. ^^

Anyhow, thanks for the review & merge.

name-snrl pushed a commit to name-snrl/nixpkgs that referenced this pull request Sep 16, 2024
* python3.pkgs.unicodeit: init at 0.7.5

* python3.pkgs.unicodeit: define CLI entrypoint

* unicodeit: init

* fixup! python3.pkgs.unicodeit: define CLI entrypoint

* fixup! python3.pkgs.unicodeit: init at 0.7.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants