python312Packages.pastedeploy: 3.0.1 -> 3.1 #341434
Conversation
ofborg
bot
added
11.by: package-maintainer
anthonyroussel
force-pushed
the
update-pastedeploy
branch
from
641f6a6 to
b2d96f2
Compare
|
Rebased against staging branch (500+ rebuilds) |
| propagatedBuildInputs = [ | ||
| build-system = [ setuptools ]; | ||
|
|
||
| dependencies = [ | ||
| setuptools |
There was a problem hiding this comment.
Are you sure setuptools is required at runtime?
There was a problem hiding this comment.
Thank you for the review!
Yes, setuptools is required for pkg_resources, see https://github.com/pasteorg/paste/blob/bc1753b00c5f342d28b1af73cd4f662b206c1f37/setup.py#L58
wegank
added
the
12.approvals: 1
| rev = "refs/tags/${version}"; | ||
| hash = "sha256-8MNeOcYPEYAfghZN/K/1v/tAAdgz/fCvuVnBoru+81Q="; | ||
| }; | ||
|
|
||
| postPatch = '' | ||
| substituteInPlace pytest.ini \ | ||
| --replace " --cov" "" | ||
| --replace-fail " --cov" "" |
There was a problem hiding this comment.
We could also use pytest-cov-stub
|
|
||
| disabled = pythonOlder "3.7"; | ||
|
|
||
| src = fetchFromGitHub { | ||
| owner = "Pylons"; | ||
| repo = pname; | ||
| repo = "pastedeploy"; | ||
| rev = "refs/tags/${version}"; | ||
| hash = "sha256-8MNeOcYPEYAfghZN/K/1v/tAAdgz/fCvuVnBoru+81Q="; |
There was a problem hiding this comment.
@anthonyroussel you didn't update the hash for the new version (which also means you built and tested against the old version's source, which happened to be in your local store as a fixed-output derivation).
There was a problem hiding this comment.
Thank you for the review!
Oops sorry, indeed, looks like I forgot to update the hash for this package.
I created this PR to fix the hash: #368915
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.