aider-chat: skip version check in tests #341441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone recently messaged me about exactly this, so thank you for the PR. |
13 tasks
aider checks for a new version and prompts for an install on each launch. These prompts cause checks to fail on the package whenever a new version of the application is released. Skip those version checks and include some dependencies missing from the dependency check.
nwjsmith
force-pushed
the
aider-check-without-autoupgrade
branch
from
409c7ab to
df8c8b2
Compare
|
@taha-yassine when you get a chance, could you merge this? |
taha-yassine
approved these changes
Sep 16, 2024
|
I approved the changes but I don't have the ability to merge it myself. |
wegank
added
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
aider checks for a new version and prompts for an install on each launch. These prompts cause checks to fail on the package whenever a new version of the application is released.
Skip those version checks and include some dependencies missing from the dependency check.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.