Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.whenever: 0.6.8 -> 0.6.9 #341454

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

pbsds
Copy link
Member

@pbsds pbsds commented Sep 12, 2024

Changelog: https://github.com/ariebovenberg/whenever/blob/refs/tags/0.6.9/CHANGELOG.rst

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pbsds pbsds marked this pull request as ready for review September 12, 2024 21:46
@pbsbot
Copy link

pbsbot commented Sep 12, 2024

Result of nixpkgs-review pr 341454 run on x86_64-linux 1

4 packages built:
  • python311Packages.whenever
  • python311Packages.whenever.dist
  • python312Packages.whenever
  • python312Packages.whenever.dist

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 13, 2024
@natsukium
Copy link
Member

Result of nixpkgs-review pr 341454 at 3dfb694 run on aarch64-darwin 1

2 packages built successfully:
  • python311Packages.whenever
  • python312Packages.whenever

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natsukium natsukium merged commit b30526a into NixOS:master Sep 13, 2024
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants