hcipy: init at 0.6.0 #341906
Open
hcipy: init at 0.6.0 #341906
+78
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
BarrOff
force-pushed
the
add-hcipy
branch
2 times, most recently
from
a5e3eab to
09457e0
Compare
FliegendeWurst
requested changes
Oct 30, 2024
BarrOff
force-pushed
the
add-hcipy
branch
2 times, most recently
from
abf582f to
a5aaa85
Compare
I have adjusted the commit message and applied all requested changes. |
FliegendeWurst
approved these changes
Nov 5, 2024
FliegendeWurst
added
the
12.approvals: 1
natsukium
reviewed
Nov 7, 2024
BarrOff
force-pushed
the
add-hcipy
branch
2 times, most recently
from
def1d53 to
935253e
Compare
wegank
removed
the
12.approvals: 1
|
@ofborg build python312Packages.hcipy |
FliegendeWurst
requested changes
Nov 10, 2024
There was a problem hiding this comment.
Tests fail on aarch64-linux
tests/test_aperture.py ................................................. [ 13%]
.............s.s.............. [ 21%]
tests/test_atmosphere.py .s.s.s.s...... [ 25%]
tests/test_config.py . [ 26%]
tests/test_coronagraphy.py ........Fatal Python error: Aborted
Please mark as broken or fix
I'm neither a developer of the project nor do I have arm64 hardware to check and debug the problem, so I can't fix it. |
FliegendeWurst
approved these changes
Nov 10, 2024
FliegendeWurst
added
the
12.approvals: 1
| setuptools-scm, | ||
|
|
||
| # dependencies | ||
| numpy, |
There was a problem hiding this comment.
Suggested change
| numpy, | |
| numpy_1, |
Package is not compatible with 2.x, which will be the new default very soon.
wegank
removed
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the HCIPy python library.
HCIPy is an open-source, modular Python package for high-contrast imaging on current and future telescopes.
More information available on the projects homepage.
I have successfully built the package and tested it's functionality.
This is the first time I add a Python package.
Help is really appreciated if I missed something.
Things done