Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.05] python311Packages.jupyterlab: 4.2.0 -> 4.2.5 #342053

Merged
merged 5 commits into from
Sep 16, 2024

Conversation

natsukium
Copy link
Member

Description of changes

fixes https://nvd.nist.gov/vuln/detail/CVE-2024-43805

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@natsukium natsukium added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Sep 15, 2024
@github-actions github-actions bot added 6.topic: python 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab labels Sep 15, 2024
@ofborg ofborg bot requested review from GaetanLepage and thomasjm September 15, 2024 13:44
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 labels Sep 15, 2024
@natsukium
Copy link
Member Author

natsukium commented Sep 15, 2024

Result of nixpkgs-review pr 342053 at 843ab11 run on aarch64-darwin 1

13 packages marked as broken and skipped:
  • python311Packages.batchspawner
  • python311Packages.dockerspawner
  • python311Packages.jupyter-contrib-nbextensions
  • python311Packages.jupyterhub
  • python311Packages.jupyterhub-ldapauthenticator
  • python311Packages.jupyterhub-systemdspawner
  • python311Packages.jupyterhub-tmpauthenticator
  • python311Packages.k-diffusion
  • python311Packages.oauthenticator
  • python311Packages.tsfresh
  • python312Packages.pynitrokey
  • python312Packages.spsdk
  • tts
22 packages failed to build:
41 packages built successfully:
  • ihaskell
  • jupyter
  • jupyter-all
  • nbqa
  • python311Packages.ansible-kernel
  • python311Packages.bqplot
  • python311Packages.bqscales
  • python311Packages.ipytablewidgets
  • python311Packages.ipyvuetify
  • python311Packages.jupyter
  • python311Packages.jupyter-collaboration
  • python311Packages.jupyter-contrib-core
  • python311Packages.jupyter-nbextensions-configurator
  • python311Packages.jupyterlab
  • python311Packages.jupyterlab-git
  • python311Packages.jupyterlab-lsp
  • python311Packages.jupytext
  • python311Packages.nbdime
  • python311Packages.nix-kernel
  • python311Packages.notebook
  • python311Packages.notedown
  • python311Packages.pydeck
  • python311Packages.pymoo
  • python311Packages.qgrid
  • streamlit (python311Packages.streamlit)
  • python311Packages.vector
  • python311Packages.vega
  • python312Packages.ipyvuetify
  • python312Packages.jupyter-collaboration
  • python312Packages.jupyter-contrib-core
  • python312Packages.jupyterlab
  • python312Packages.jupyterlab-git
  • python312Packages.jupyterlab-lsp
  • python312Packages.jupytext
  • python312Packages.nbdime
  • python312Packages.nix-kernel
  • python312Packages.notebook
  • python312Packages.notedown
  • python312Packages.pymoo
  • python312Packages.vector
  • quarto

Result of nixpkgs-review pr 342053 at 843ab11 run on x86_64-linux 1

10 packages marked as broken and skipped:
  • python311Packages.bambi
  • python311Packages.distrax
  • python311Packages.elegy
  • python311Packages.jupyter-contrib-nbextensions
  • python311Packages.openllm
  • python311Packages.rlax
  • python311Packages.treex
  • python312Packages.pynitrokey
  • python312Packages.spsdk
  • tts
3 packages failed to build:
90 packages built successfully:
  • cantor
  • ihaskell
  • jupyter
  • jupyter-all
  • labplot
  • manim (python311Packages.manim)
  • manim-slides
  • nbqa
  • nitrokey-app2
  • pynitrokey (python311Packages.pynitrokey)
  • python311Packages.ansible-kernel
  • python311Packages.arviz
  • python311Packages.augmax
  • python311Packages.batchspawner
  • python311Packages.bqplot
  • python311Packages.bqscales
  • python311Packages.dalle-mini
  • python311Packages.dm-haiku
  • python311Packages.dockerspawner
  • python311Packages.einops
  • python311Packages.encodec
  • python311Packages.experiment-utilities
  • python311Packages.flax
  • python311Packages.ipytablewidgets
  • python311Packages.ipyvuetify
  • python311Packages.jupyter
  • python311Packages.jupyter-collaboration
  • python311Packages.jupyter-contrib-core
  • python311Packages.jupyter-nbextensions-configurator
  • python311Packages.jupyterhub
  • python311Packages.jupyterhub-ldapauthenticator
  • python311Packages.jupyterhub-systemdspawner
  • python311Packages.jupyterhub-tmpauthenticator
  • python311Packages.jupyterlab
  • python311Packages.jupyterlab-git
  • python311Packages.jupyterlab-lsp
  • python311Packages.jupytext
  • python311Packages.k-diffusion
  • python311Packages.layoutparser
  • python311Packages.manim-slides
  • python311Packages.mkdocs-jupyter
  • python311Packages.nbdime
  • python311Packages.nikola
  • python311Packages.nix-kernel
  • python311Packages.notebook
  • python311Packages.notedown
  • python311Packages.oauthenticator
  • python311Packages.pdfplumber
  • python311Packages.pyannote-audio
  • python311Packages.pydeck
  • python311Packages.pymc
  • python311Packages.pymoo
  • python311Packages.pytest-notebook
  • python311Packages.qgrid
  • python311Packages.rotary-embedding-torch
  • python311Packages.spsdk
  • streamlit (python311Packages.streamlit)
  • python311Packages.tsfresh
  • python311Packages.vector
  • python311Packages.vega
  • python311Packages.vqgan-jax
  • python311Packages.xarray-einstats
  • python312Packages.ipyvuetify
  • python312Packages.jupyter-collaboration
  • python312Packages.jupyter-contrib-core
  • python312Packages.jupyterlab
  • python312Packages.jupyterlab-git
  • python312Packages.jupyterlab-lsp
  • python312Packages.jupytext
  • python312Packages.layoutparser
  • python312Packages.manim
  • python312Packages.manim-slides
  • python312Packages.mkdocs-jupyter
  • python312Packages.nbdime
  • python312Packages.nikola
  • python312Packages.nix-kernel
  • python312Packages.notebook
  • python312Packages.notedown
  • python312Packages.pdfplumber
  • python312Packages.pymoo
  • python312Packages.pytest-notebook
  • python312Packages.vector
  • quarto
  • rstudio
  • rstudio-server
  • rstudioServerWrapper
  • rstudioWrapper
  • sage
  • sageWithDoc
  • whisper-ctranslate2

@risicle
Copy link
Contributor

risicle commented Sep 15, 2024

I would suggest that we could just patch with jupyterlab/jupyterlab@88e24ba to avoid the big diff jupyterlab/jupyterlab@v4.2.0...v4.2.5

..but I'm guessing we don't actually build our own assets for this package anyway?

@natsukium
Copy link
Member Author

..but I'm guessing we don't actually build our own assets for this package anyway?

Unfortunately, we can't handle the yarn berry lockfile in nixpkgs, and we can't build it from the source. (#254369)
It would also be difficult to patch transpiled javascript.😢

Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review reveals no new failures, macos 12 x86_64 & nixos x86_64

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 15, 2024
@fabianhjr fabianhjr merged commit f5173c0 into NixOS:release-24.05 Sep 16, 2024
28 of 30 checks passed
@natsukium natsukium deleted the jupyterlab/backport branch September 16, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants