zfs: Make latestCompatibleLinuxPackages always point at a vanilla kernel #342176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
|
pinging @amarshall listed as a maintainer |
ofborg
bot
added
10.rebuild-darwin: 0
|
The change causing this problem apparently also reached stable (i laned on -gnu) which breaks my graphics support. Please backport this PR also to 24.05. |
|
I've tested your pull request by cherry picking it manually onto stable. It restores expedited behavior. 👍 |
amarshall
reviewed
Sep 16, 2024
SuperSandro2000
added
1.severity: blocker
As it was before, this would filter all available kernel packages and pick the one with the highest version that was supported by zfs. This included variants like linux_libre and linux_rt. When multiple kernels of the same version were available, the choice of which one was selected was ill-defined (determined by ordering of attrs I think). The result was that while zfs support was lagging behind the latest LTS, this almost always pointed at a vanilla kernel, but since 636134b it pointed at a linux_libre. This is effectively a breaking change, so should be avoided.
shelvacu
force-pushed
the
patch-fix-zfs-kernel-version
branch
from
8d71f19 to
af2e61e
Compare
shelvacu
changed the title
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it was before, this would filter all available kernel packages and pick the one with the highest version that was supported by zfs. This included variants like linux_libre and linux_rt. When multiple kernels of the same version were available, the choice of which one was selected was ill-defined (determined by ordering of attrs I think).
The result was that while zfs support was lagging behind the latest LTS, this almost always pointed at a mainline kernel, but since 636134b it pointed at a linux_libre. This is effectively a breaking change, so should be avoided.
Things done
nix-build -A nixosTests.zfsnix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usageAdd a 👍 reaction to pull requests you find important.