xen: cleanup, code quality improvements #342915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also makes it slightly more readable by adding line breaks between attributes and reordering the knownVulnerabilities attribute to be closer to the maintainers attribute, as they have similar checks. Signed-off-by: Fernando Rodrigues <[email protected]>
Instead of using multiple inherit calls, just use a single one. Signed-off-by: Fernando Rodrigues <[email protected]>
xenproject.org is the Xen Project's official domain. xen.org is deprecated and we should avoid referring to Xen as just "xen" whenever possible, due to a messy legal history with Citrix. Signed-off-by: Fernando Rodrigues <[email protected]>
SigmaSquadron
force-pushed
the
xen-more-code-quality
branch
from
33ce2ba to
7a886e7
Compare
SigmaSquadron
changed the title
SigmaSquadron
added
the
11.by: package-maintainer
emilazy
reviewed
Sep 19, 2024
| @@ -120,13 +127,13 @@ for version in "${supportedVersions[@]}"; do | |||
| echo -e "Found the following patches:\n \e[1;32mXen\e[0m: \e[1;33m$discoveredXenPatchesEcho\e[0m\n \e[1;36mQEMU\e[0m: \e[1;33m$discoveredQEMUPatchesEcho\e[0m\n \e[1;36mSeaBIOS\e[0m: \e[1;33m$discoveredSeaBIOSPatchesEcho\e[0m\n \e[1;36mOVMF\e[0m: \e[1;33m$discoveredOVMFPatchesEcho\e[0m\n \e[1;36miPXE\e[0m: \e[1;33m$discoveredIPXEPatchesEcho\e[0m" | |||
|
|
|||
| # Prepare patches that are called in ./patches.nix. | |||
| defaultPatchListInit=("QUBES_REPRODUCIBLE_BUILDS" "XSA_458" "XSA_460" "XSA_461" ) | |||
| defaultPatchListInit=("QUBES_REPRODUCIBLE_BUILDS" "XSA_460" "XSA_461" ) | |||
There was a problem hiding this comment.
Already included in 4.17.5, 4.18.3 and 4.19.0, so it's unused.
emilazy
reviewed
Sep 19, 2024
pkgs/applications/virtualization/xen/generic/0000-xen-ipxe-src-generic.patch
Outdated
Show resolved
Hide resolved
SigmaSquadron
force-pushed
the
xen-more-code-quality
branch
from
7a886e7 to
2cbee46
Compare
This comment was marked as outdated.
This comment was marked as outdated.
None of our Xen branches need it anymore. Signed-off-by: Fernando Rodrigues <[email protected]>
- Drop `-ie` flags for grep; - Add more `doing things...done` echo stanzas so it's clearer when a part of the script has concluded; - Add a note explaining why QEMU and OVMF take so long to fetch; - Add a TODO for future work at the top of the file. Signed-off-by: Fernando Rodrigues <[email protected]>
|
Big surprise. I was stupid and forgot how newlines work. Result of 28 packages built:
|
This resolves the spurious 'directory not found' errors in the xen-slim builds. Signed-off-by: Fernando Rodrigues <[email protected]>
SigmaSquadron
force-pushed
the
xen-more-code-quality
branch
from
2cbee46 to
5c62c3d
Compare
emilazy
approved these changes
Sep 19, 2024
|
Part II: #343111 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Minor changes and a cherry-pick of #341429 in preparation for a larger PR that begins building the MiniOS stubdomains.
Things done
I've been dogfooding this branch for a while now.
nix-shell -p nixpkgs-review --run "nixpkgs-review pr 342915". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.