Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elasticsearchPlugins.analysis-smartcn: init at 7.17.16 #343320

Merged

Conversation

secobarbital
Copy link
Contributor

@secobarbital secobarbital commented Sep 20, 2024

Description of changes

Added the analysis-smartcn elasticsearch plugin.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Sep 20, 2024
@ofborg ofborg bot requested a review from offlinehacker September 20, 2024 19:50
@secobarbital secobarbital changed the title elasticsearchPlugins: add analysis-smartcn plugin elasticsearchPlugins.analysis-smartcn: init at 7.17.16 Sep 23, 2024
@secobarbital
Copy link
Contributor Author

Hi, can I get a review for this trivial change, please?

Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one small suggestion

pkgs/servers/search/elasticsearch/plugins.nix Outdated Show resolved Hide resolved
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 3, 2024
@secobarbital
Copy link
Contributor Author

Anybody can merge?

@FliegendeWurst
Copy link
Member

FliegendeWurst commented Nov 20, 2024

Would be good to squash the commits so there is only one. First commit message should be like PR title.

Edit: actually, nevermind. There should be two. But both should conform to the guidelines.

@secobarbital secobarbital force-pushed the elasticsearchPlugins-smartcn branch from d869970 to f503b2e Compare November 23, 2024 04:01
@secobarbital
Copy link
Contributor Author

Thank you. Reworded the commits.

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 23, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 24, 2024
@FliegendeWurst FliegendeWurst merged commit d312358 into NixOS:master Dec 19, 2024
35 checks passed
@secobarbital secobarbital deleted the elasticsearchPlugins-smartcn branch January 10, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants