-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elasticsearchPlugins.analysis-smartcn: init at 7.17.16 #343320
elasticsearchPlugins.analysis-smartcn: init at 7.17.16 #343320
Conversation
Hi, can I get a review for this trivial change, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one small suggestion
Anybody can merge? |
Edit: actually, nevermind. There should be two. But both should conform to the guidelines. |
d869970
to
f503b2e
Compare
Thank you. Reworded the commits. |
Description of changes
Added the analysis-smartcn elasticsearch plugin.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.