Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.phylophlan: init at 3.1.1 #343699

Closed
wants to merge 1 commit into from
Closed

python3Packages.phylophlan: init at 3.1.1 #343699

wants to merge 1 commit into from

Conversation

theobori
Copy link
Member

@theobori theobori commented Sep 22, 2024 •
edited
Loading

Description of changes

Fixes #343368

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@theobori theobori mentioned this pull request Sep 22, 2024
Closed
Pandapip1
Pandapip1 suggested changes Sep 22, 2024
View reviewed changes
pkgs/by-name/ph/phylophlan/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ph/phylophlan/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ph/phylophlan/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ph/phylophlan/package.nix Outdated Show resolved Hide resolved
@Pandapip1
Copy link
Contributor

Result of nixpkgs-review pr 343699 run on x86_64-linux 1

2 packages built:
  • phylophlan
  • phylophlan.dist

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 22, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1972

@FliegendeWurst
Copy link
Member

@ofborg build python312Packages.phylophlan

@FliegendeWurst
Copy link
Member

@ofborg build phylophlan

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 10, 2024
@theobori theobori closed this by deleting the head repository Nov 17, 2024
@Pandapip1
Copy link
Contributor

:|

@theobori
Copy link
Member Author

:|

Yes I deleted my nixpkgs fork :D.
I will recreate a PR for this pacakge when I have time don't worry.

@theobori
Copy link
Member Author

The new PR is here #356788.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pandapip1 Pandapip1 Pandapip1 approved these changes

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: phylophlan
5 participants
@theobori @Pandapip1 @nixos-discourse @FliegendeWurst @wegank