Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.lockfile: Remove usage of nose; modernize #343765

Merged
merged 2 commits into from
Sep 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions pkgs/development/python-modules/lockfile/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
fetchPypi,
setuptools,
pbr,
nose,
pytestCheckHook,
}:

buildPythonPackage rec {
Expand All @@ -14,25 +14,21 @@ buildPythonPackage rec {

src = fetchPypi {
inherit pname version;
sha256 = "6aed02de03cba24efabcd600b30540140634fc06cfa603822d508d5361e9f799";
hash = "sha256-au0C3gPLok76vNYAswVAFAY0/AbPpgOCLVCNU2Hp95k=";
};

patches = [ ./fix-tests.patch ];

build-system = [
pbr
setuptools
];

nativeCheckInputs = [ nose ];

checkPhase = ''
runHook preCheck
nosetests
runHook postcheck
'';
nativeCheckInputs = [ pytestCheckHook ];

meta = with lib; {
meta = {
homepage = "https://launchpad.net/pylockfile";
description = "Platform-independent advisory file locking capability for Python applications";
license = licenses.asl20;
license = lib.licenses.asl20;
};
}
28 changes: 28 additions & 0 deletions pkgs/development/python-modules/lockfile/fix-tests.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
diff --git a/test/compliancetest.py b/test/compliancetest.py
index bf4e59c..f55e258 100644
--- a/test/compliancetest.py
+++ b/test/compliancetest.py
@@ -6,18 +6,19 @@ import lockfile


class ComplianceTest(object):
- def __init__(self):
- self.saved_class = lockfile.LockFile
+ @classmethod
+ def setup_class(cls):
+ cls.saved_class = lockfile.LockFile

def _testfile(self):
"""Return platform-appropriate file. Helper for tests."""
import tempfile
return os.path.join(tempfile.gettempdir(), 'trash-%s' % os.getpid())

- def setup(self):
+ def setup_method(self):
lockfile.LockFile = self.class_to_test

- def teardown(self):
+ def teardown_method(self):
try:
tf = self._testfile()
if os.path.isdir(tf):