Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evdi: 1.14.6 -> 1.14.7 #344700

Merged
merged 1 commit into from
Nov 20, 2024
Merged

evdi: 1.14.6 -> 1.14.7 #344700

merged 1 commit into from
Nov 20, 2024

Conversation

Lappihuan
Copy link
Contributor

Description of changes

https://github.com/DisplayLink/evdi/releases/tag/v1.14.7

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Sep 26, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Sep 26, 2024
Copy link
Member

@fabianhjr fabianhjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to nixpkgs, could you reword your commit to conform to the commit conventions?

https://github.com/NixOS/nixpkgs/blob/24.05/pkgs/README.md#commit-conventions

It affects what ofborg (CI bot) builds as documented here: https://github.com/nixos/ofborg?tab=readme-ov-file#automatic-building

@Bot-wxt1221
Copy link
Member

@ofborg build evdi

Copy link
Member

@Bot-wxt1221 Bot-wxt1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to move it to by-name. Even though all package will be moved automatically in the end.

@Lappihuan Lappihuan changed the title upgrade evdi to 1.14.7 evdi: 1.14.6 -> 1.14.7 Oct 3, 2024
@Lappihuan
Copy link
Contributor Author

sry, only got arround to it now.
the commit message should be fixed

@fabianhjr fabianhjr requested a review from Bot-wxt1221 October 11, 2024 15:12
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 15, 2024
@drupol drupol merged commit cbc70ce into NixOS:master Nov 20, 2024
25 checks passed
@drupol
Copy link
Contributor

drupol commented Nov 20, 2024

Follow-up: #357624

@drupol
Copy link
Contributor

drupol commented Nov 20, 2024

@Lappihuan Welcome and thanks for your first contribution to the Nix project! Keep PRs coming :)

@fabianhjr fabianhjr added the backport release-24.11 Backport PR automatically label Nov 20, 2024
Copy link
Contributor

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle! backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants