-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evdi: 1.14.6 -> 1.14.7 #344700
evdi: 1.14.6 -> 1.14.7 #344700
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing to nixpkgs, could you reword your commit to conform to the commit conventions?
https://github.com/NixOS/nixpkgs/blob/24.05/pkgs/README.md#commit-conventions
It affects what ofborg (CI bot) builds as documented here: https://github.com/nixos/ofborg?tab=readme-ov-file#automatic-building
@ofborg build evdi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to move it to by-name. Even though all package will be moved automatically in the end.
f6c6ff2
to
b6d57c6
Compare
sry, only got arround to it now. |
Follow-up: #357624 |
@Lappihuan Welcome and thanks for your first contribution to the Nix project! Keep PRs coming :) |
Successfully created backport PR for |
Description of changes
https://github.com/DisplayLink/evdi/releases/tag/v1.14.7
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.