sview: init at 20_08

[Mx2uller]

Description of changes

Cross-platform solution to view 3D stereoscopic videos and images.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[Mx2uller]

Hi, I made changes like you suggested. Initially I did have buildInputs but tried to build package without it, and it built successfully and run. For some reason everything in nativeBuildInputs stays alive in nix store, even after gc.

[FliegendeWurst]

Please override to use gccStdenv on Darwin, or patch the makefile to use generic cc:

       > cp -f -r textures/* build/sView.app/Contents/MacOS/textures/
       > g++ -O3 -std=c++0x -Wall -fPIC -DST_HAVE_MONGOOSE -I/private/tmp/nix-build-sview-20_08.drv-0/source/3rdparty/include -I/private/tmp/nix-build-sview-20_08.drv-0/source/include -DAPP_PREFIX="\"/usr\"" -mmacosx-version-min=10.10 -I/nix/store/cxlb2dhd940yks83105zvwn4z3sga4d8-freetype-2.13.3-dev/include/freetype2   -c -o /private/tmp/nix-build-sview-20_08.drv-0/source/StShared/StAVFrame.o /private/tmp/nix-build-sview-20_08.drv-0/source/StShared/StAVFrame.cpp
       > /nix/store/7ka6l083nbz2q7p9x8xi1nf9s83sa6w4-bash-5.2p37/bin/bash: line 1: g++: command not found
       > make: *** [<builtin>: /private/tmp/nix-build-sview-20_08.drv-0/source/StShared/StAVFrame.o] Error 127

[Mx2uller]

Hi, I am going to revert platforms.unix back to linux as I am unable to build and test locally for darwin.

[FliegendeWurst]

For Darwin, I tried

diff --git a/pkgs/by-name/sv/sview/package.nix b/pkgs/by-name/sv/sview/package.nix
index 7f62b2195278..b7ea2b9e977c 100644
--- a/pkgs/by-name/sv/sview/package.nix
+++ b/pkgs/by-name/sv/sview/package.nix
@@ -46,6 +46,14 @@ stdenv.mkDerivation rec {
     openal
   ];

+  makeFlags = [
+    "CC=${stdenv.cc.targetPrefix}cc"
+    "CXX=${stdenv.cc.targetPrefix}c++"
+    "LD=${stdenv.cc.targetPrefix}c++"
+  ];
+
+  enableParallelBuilding = true;
+
   fontsConf = makeFontsConf {
     fontDirectories = [
       nanum
@@ -80,6 +88,6 @@ stdenv.mkDerivation rec {
     ];
     maintainers = with maintainers; [ mx2uller ];
     mainProgram = "sView";
-    platforms = platforms.linux;
+    platforms = platforms.unix;
   };
 }

However the build still fails due to missing ibtool.

[Mx2uller]

Is it possible to test and build on my linux machine for darwin?

For Darwin, I tried

diff --git a/pkgs/by-name/sv/sview/package.nix b/pkgs/by-name/sv/sview/package.nix
index 7f62b2195278..b7ea2b9e977c 100644
--- a/pkgs/by-name/sv/sview/package.nix
+++ b/pkgs/by-name/sv/sview/package.nix
@@ -46,6 +46,14 @@ stdenv.mkDerivation rec {
     openal
   ];

+  makeFlags = [
+    "CC=${stdenv.cc.targetPrefix}cc"
+    "CXX=${stdenv.cc.targetPrefix}c++"
+    "LD=${stdenv.cc.targetPrefix}c++"
+  ];
+
+  enableParallelBuilding = true;
+
   fontsConf = makeFontsConf {
     fontDirectories = [
       nanum
@@ -80,6 +88,6 @@ stdenv.mkDerivation rec {
     ];
     maintainers = with maintainers; [ mx2uller ];
     mainProgram = "sView";
-    platforms = platforms.linux;
+    platforms = platforms.unix;
   };
 }

However the build still fails due to missing ibtool.

[FliegendeWurst]

I always use the community builder https://nix-community.org/community-builder/

However I think the ibtool issue is a blocker. I tried xib2nib which provides it, but it seems that is not the right package.

[Mx2uller]

Currently I do not have access to community builder, for now I cleaned up commit history so its one commit per file.

[FliegendeWurst]

By the way, if you add your Git email ([email protected]) to Github as secondary email, the commits show up as yours.