Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php83: 8.3.11 -> 8.3.12, php82: 8.2.23 -> 8.2.24, php81: 8.1.29 -> 8.1.30 #344937

Merged
merged 4 commits into from
Sep 28, 2024

Conversation

LeSuisse
Copy link
Contributor

@LeSuisse LeSuisse commented Sep 27, 2024

Description of changes

Fixes CVE-2024-8927, CVE-2024-9026 and CVE-2024-8925.

Changes:
https://www.php.net/ChangeLog-8.php#8.3.12
https://www.php.net/ChangeLog-8.php#8.2.24
https://www.php.net/ChangeLog-8.php#8.1.30

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

4 packages failed to build:
  • php81Packages.psysh
  • php82Packages.psysh
  • php83Extensions.couchbase
  • php83Packages.psysh
590 packages built:
  • adminer
  • adminerevo
  • php (apacheHttpdPackages.php)
  • bloom
  • bookstack
  • composer-require-checker
  • davis
  • easyeffects
  • easyeffects.debug
  • engelsystem
  • firefly-iii
  • firefly-iii-data-importer
  • flarum
  • frankenphp
  • freshrss
  • gnomeExtensions.easyeffects-preset-selector
  • grocy
  • icingaweb2
  • ifm-web
  • laravel
  • librenms
  • libsForQt5.kcachegrind
  • lsp-plugins
  • lsp-plugins.dev
  • lsp-plugins.doc
  • matomo
  • matomo-beta
  • matomo_5
  • movim
  • n98-magerun
  • n98-magerun2
  • nagios
  • nextcloud-news-updater
  • nextcloud-news-updater.dist
  • nominatim
  • paratest
  • pdepend
  • pest
  • phel
  • phoronix-test-suite
  • php81
  • php81Extensions.amqp
  • php81Extensions.apcu
  • php81Extensions.apcu.dev
  • php81Extensions.ast
  • php81Extensions.bcmath
  • php81Extensions.bcmath.dev
  • php81Extensions.bz2
  • php81Extensions.bz2.dev
  • php81Extensions.calendar
  • php81Extensions.calendar.dev
  • php81Extensions.couchbase
  • php81Extensions.ctype
  • php81Extensions.ctype.dev
  • php81Extensions.curl
  • php81Extensions.curl.dev
  • php81Extensions.datadog_trace
  • php81Extensions.dba
  • php81Extensions.dba.dev
  • php81Extensions.dom
  • php81Extensions.dom.dev
  • php81Extensions.ds
  • php81Extensions.enchant
  • php81Extensions.enchant.dev
  • php81Extensions.event
  • php81Extensions.exif
  • php81Extensions.exif.dev
  • php81Extensions.ffi
  • php81Extensions.ffi.dev
  • php81Extensions.fileinfo
  • php81Extensions.fileinfo.dev
  • php81Extensions.filter
  • php81Extensions.filter.dev
  • php81Extensions.ftp
  • php81Extensions.ftp.dev
  • php81Extensions.gd
  • php81Extensions.gd.dev
  • php81Extensions.gettext
  • php81Extensions.gettext.dev
  • php81Extensions.gmp
  • php81Extensions.gmp.dev
  • php81Extensions.gnupg
  • php81Extensions.grpc
  • php81Extensions.iconv
  • php81Extensions.iconv.dev
  • php81Extensions.igbinary
  • php81Extensions.igbinary.dev
  • php81Extensions.imagick
  • php81Extensions.imap
  • php81Extensions.imap.dev
  • php81Extensions.inotify
  • php81Extensions.intl
  • php81Extensions.intl.dev
  • php81Extensions.ldap
  • php81Extensions.ldap.dev
  • php81Extensions.mailparse
  • php81Extensions.maxminddb
  • php81Extensions.mbstring
  • php81Extensions.mbstring.dev
  • php81Extensions.memcache
  • php81Extensions.memcached
  • php81Extensions.meminfo
  • php81Extensions.memprof
  • php81Extensions.mongodb
  • php81Extensions.msgpack
  • php81Extensions.mysqli
  • php81Extensions.mysqli.dev
  • php81Extensions.mysqlnd
  • php81Extensions.mysqlnd.dev
  • php81Extensions.oci8
  • php81Extensions.opcache
  • php81Extensions.opcache.dev
  • php81Extensions.openssl
  • php81Extensions.openssl.dev
  • php81Extensions.openswoole
  • php81Extensions.opentelemetry
  • php81Extensions.pcntl
  • php81Extensions.pcntl.dev
  • php81Extensions.pcov
  • php81Extensions.pdlib
  • php81Extensions.pdo
  • php81Extensions.pdo.dev
  • php81Extensions.pdo_dblib
  • php81Extensions.pdo_dblib.dev
  • php81Extensions.pdo_mysql
  • php81Extensions.pdo_mysql.dev
  • php81Extensions.pdo_oci
  • php81Extensions.pdo_odbc
  • php81Extensions.pdo_odbc.dev
  • php81Extensions.pdo_pgsql
  • php81Extensions.pdo_pgsql.dev
  • php81Extensions.pdo_sqlite
  • php81Extensions.pdo_sqlite.dev
  • php81Extensions.pdo_sqlsrv
  • php81Extensions.pgsql
  • php81Extensions.pgsql.dev
  • php81Extensions.phalcon
  • php81Extensions.pinba
  • php81Extensions.posix
  • php81Extensions.posix.dev
  • php81Extensions.protobuf
  • php81Extensions.pspell
  • php81Extensions.rdkafka
  • php81Extensions.readline
  • php81Extensions.readline.dev
  • php81Extensions.redis
  • php81Extensions.rrd
  • php81Extensions.session
  • php81Extensions.session.dev
  • php81Extensions.shmop
  • php81Extensions.shmop.dev
  • php81Extensions.simplexml
  • php81Extensions.simplexml.dev
  • php81Extensions.smbclient
  • php81Extensions.snmp
  • php81Extensions.snmp.dev
  • php81Extensions.snuffleupagus
  • php81Extensions.soap
  • php81Extensions.soap.dev
  • php81Extensions.sockets
  • php81Extensions.sockets.dev
  • php81Extensions.sodium
  • php81Extensions.sodium.dev
  • php81Extensions.spx
  • php81Extensions.sqlite3
  • php81Extensions.sqlite3.dev
  • php81Extensions.sqlsrv
  • php81Extensions.ssh2
  • php81Extensions.swoole
  • php81Extensions.sysvmsg
  • php81Extensions.sysvmsg.dev
  • php81Extensions.sysvsem
  • php81Extensions.sysvsem.dev
  • php81Extensions.sysvshm
  • php81Extensions.sysvshm.dev
  • php81Extensions.tidy
  • php81Extensions.tidy.dev
  • php81Extensions.tokenizer
  • php81Extensions.tokenizer.dev
  • php81Extensions.uv
  • php81Extensions.vld
  • php81Extensions.xdebug
  • php81Extensions.xml
  • php81Extensions.xml.dev
  • php81Extensions.xmlreader
  • php81Extensions.xmlreader.dev
  • php81Extensions.xmlwriter
  • php81Extensions.xmlwriter.dev
  • php81Extensions.xsl
  • php81Extensions.xsl.dev
  • php81Extensions.yaml
  • php81Extensions.zend_test
  • php81Extensions.zend_test.dev
  • php81Extensions.zip
  • php81Extensions.zip.dev
  • php81Extensions.zlib
  • php81Extensions.zlib.dev
  • php81Extensions.zstd
  • php81Packages.box (php82Packages.box ,php83Packages.box ,php84Packages.box)
  • php81Packages.castor
  • php81Packages.composer
  • php81Packages.composer-local-repo-plugin
  • php81Packages.cyclonedx-php-composer
  • php81Packages.deployer
  • php81Packages.grumphp
  • php81Packages.phan
  • php81Packages.phing
  • php81Packages.phive
  • php81Packages.php-codesniffer
  • php81Packages.php-cs-fixer
  • php81Packages.php-parallel-lint
  • php81Packages.phpinsights
  • php81Packages.phpmd
  • php81Packages.phpspy
  • php81Packages.phpstan
  • php81Packages.psalm
  • php82Extensions.amqp
  • php82Extensions.apcu
  • php82Extensions.apcu.dev
  • php82Extensions.ast
  • php82Extensions.bcmath
  • php82Extensions.bcmath.dev
  • php82Extensions.bz2
  • php82Extensions.bz2.dev
  • php82Extensions.calendar
  • php82Extensions.calendar.dev
  • php82Extensions.couchbase
  • php82Extensions.ctype
  • php82Extensions.ctype.dev
  • php82Extensions.curl
  • php82Extensions.curl.dev
  • php82Extensions.datadog_trace
  • php82Extensions.dba
  • php82Extensions.dba.dev
  • php82Extensions.dom
  • php82Extensions.dom.dev
  • php82Extensions.ds
  • php82Extensions.enchant
  • php82Extensions.enchant.dev
  • php82Extensions.event
  • php82Extensions.exif
  • php82Extensions.exif.dev
  • php82Extensions.ffi
  • php82Extensions.ffi.dev
  • php82Extensions.fileinfo
  • php82Extensions.fileinfo.dev
  • php82Extensions.filter
  • php82Extensions.filter.dev
  • php82Extensions.ftp
  • php82Extensions.ftp.dev
  • php82Extensions.gd
  • php82Extensions.gd.dev
  • php82Extensions.gettext
  • php82Extensions.gettext.dev
  • php82Extensions.gmp
  • php82Extensions.gmp.dev
  • php82Extensions.gnupg
  • php82Extensions.grpc
  • php82Extensions.iconv
  • php82Extensions.iconv.dev
  • php82Extensions.igbinary
  • php82Extensions.igbinary.dev
  • php82Extensions.imagick
  • php82Extensions.imap
  • php82Extensions.imap.dev
  • php82Extensions.inotify
  • php82Extensions.intl
  • php82Extensions.intl.dev
  • php82Extensions.ldap
  • php82Extensions.ldap.dev
  • php82Extensions.mailparse
  • php82Extensions.maxminddb
  • php82Extensions.mbstring
  • php82Extensions.mbstring.dev
  • php82Extensions.memcache
  • php82Extensions.memcached
  • php82Extensions.meminfo
  • php82Extensions.memprof
  • php82Extensions.mongodb
  • php82Extensions.msgpack
  • php82Extensions.mysqli
  • php82Extensions.mysqli.dev
  • php82Extensions.mysqlnd
  • php82Extensions.mysqlnd.dev
  • php82Extensions.oci8
  • php82Extensions.opcache
  • php82Extensions.opcache.dev
  • php82Extensions.openssl
  • php82Extensions.openssl.dev
  • php82Extensions.openswoole
  • php82Extensions.opentelemetry
  • php82Extensions.pcntl
  • php82Extensions.pcntl.dev
  • php82Extensions.pcov
  • php82Extensions.pdlib
  • php82Extensions.pdo
  • php82Extensions.pdo.dev
  • php82Extensions.pdo_dblib
  • php82Extensions.pdo_dblib.dev
  • php82Extensions.pdo_mysql
  • php82Extensions.pdo_mysql.dev
  • php82Extensions.pdo_oci
  • php82Extensions.pdo_odbc
  • php82Extensions.pdo_odbc.dev
  • php82Extensions.pdo_pgsql
  • php82Extensions.pdo_pgsql.dev
  • php82Extensions.pdo_sqlite
  • php82Extensions.pdo_sqlite.dev
  • php82Extensions.pdo_sqlsrv
  • php82Extensions.pgsql
  • php82Extensions.pgsql.dev
  • php82Extensions.phalcon
  • php82Extensions.pinba
  • php82Extensions.posix
  • php82Extensions.posix.dev
  • php82Extensions.protobuf
  • php82Extensions.pspell
  • php82Extensions.rdkafka
  • php82Extensions.readline
  • php82Extensions.readline.dev
  • php82Extensions.redis
  • php82Extensions.rrd
  • php82Extensions.session
  • php82Extensions.session.dev
  • php82Extensions.shmop
  • php82Extensions.shmop.dev
  • php82Extensions.simplexml
  • php82Extensions.simplexml.dev
  • php82Extensions.smbclient
  • php82Extensions.snmp
  • php82Extensions.snmp.dev
  • php82Extensions.snuffleupagus
  • php82Extensions.soap
  • php82Extensions.soap.dev
  • php82Extensions.sockets
  • php82Extensions.sockets.dev
  • php82Extensions.sodium
  • php82Extensions.sodium.dev
  • php82Extensions.spx
  • php82Extensions.sqlite3
  • php82Extensions.sqlite3.dev
  • php82Extensions.sqlsrv
  • php82Extensions.ssh2
  • php82Extensions.swoole
  • php82Extensions.sysvmsg
  • php82Extensions.sysvmsg.dev
  • php82Extensions.sysvsem
  • php82Extensions.sysvsem.dev
  • php82Extensions.sysvshm
  • php82Extensions.sysvshm.dev
  • php82Extensions.tidy
  • php82Extensions.tidy.dev
  • php82Extensions.tokenizer
  • php82Extensions.tokenizer.dev
  • php82Extensions.uv
  • php82Extensions.vld
  • php82Extensions.xdebug
  • php82Extensions.xml
  • php82Extensions.xml.dev
  • php82Extensions.xmlreader
  • php82Extensions.xmlreader.dev
  • php82Extensions.xmlwriter
  • php82Extensions.xmlwriter.dev
  • php82Extensions.xsl
  • php82Extensions.xsl.dev
  • php82Extensions.yaml
  • php82Extensions.zend_test
  • php82Extensions.zend_test.dev
  • php82Extensions.zip
  • php82Extensions.zip.dev
  • php82Extensions.zlib
  • php82Extensions.zlib.dev
  • php82Extensions.zstd
  • php82Packages.castor
  • php82Packages.composer
  • php82Packages.composer-local-repo-plugin
  • php82Packages.cyclonedx-php-composer
  • php82Packages.deployer
  • php82Packages.grumphp
  • php82Packages.phan
  • php82Packages.phing
  • php82Packages.phive
  • php82Packages.php-codesniffer
  • php82Packages.php-cs-fixer
  • php82Packages.php-parallel-lint
  • php82Packages.phpinsights
  • php82Packages.phpmd
  • php82Packages.phpspy
  • php82Packages.phpstan
  • php82Packages.psalm
  • php83
  • php83Extensions.amqp
  • php83Extensions.apcu
  • php83Extensions.apcu.dev
  • php83Extensions.ast
  • php83Extensions.bcmath
  • php83Extensions.bcmath.dev
  • php83Extensions.bz2
  • php83Extensions.bz2.dev
  • php83Extensions.calendar
  • php83Extensions.calendar.dev
  • php83Extensions.ctype
  • php83Extensions.ctype.dev
  • php83Extensions.curl
  • php83Extensions.curl.dev
  • php83Extensions.datadog_trace
  • php83Extensions.dba
  • php83Extensions.dba.dev
  • php83Extensions.dom
  • php83Extensions.dom.dev
  • php83Extensions.ds
  • php83Extensions.enchant
  • php83Extensions.enchant.dev
  • php83Extensions.event
  • php83Extensions.exif
  • php83Extensions.exif.dev
  • php83Extensions.ffi
  • php83Extensions.ffi.dev
  • php83Extensions.fileinfo
  • php83Extensions.fileinfo.dev
  • php83Extensions.filter
  • php83Extensions.filter.dev
  • php83Extensions.ftp
  • php83Extensions.ftp.dev
  • php83Extensions.gd
  • php83Extensions.gd.dev
  • php83Extensions.gettext
  • php83Extensions.gettext.dev
  • php83Extensions.gmp
  • php83Extensions.gmp.dev
  • php83Extensions.gnupg
  • php83Extensions.grpc
  • php83Extensions.iconv
  • php83Extensions.iconv.dev
  • php83Extensions.igbinary
  • php83Extensions.igbinary.dev
  • php83Extensions.imagick
  • php83Extensions.imap
  • php83Extensions.inotify
  • php83Extensions.intl
  • php83Extensions.intl.dev
  • php83Extensions.ldap
  • php83Extensions.ldap.dev
  • php83Extensions.mailparse
  • php83Extensions.maxminddb
  • php83Extensions.mbstring
  • php83Extensions.mbstring.dev
  • php83Extensions.memcache
  • php83Extensions.memcached
  • php83Extensions.meminfo
  • php83Extensions.memprof
  • php83Extensions.mongodb
  • php83Extensions.msgpack
  • php83Extensions.mysqli
  • php83Extensions.mysqli.dev
  • php83Extensions.mysqlnd
  • php83Extensions.mysqlnd.dev
  • php83Extensions.oci8
  • php83Extensions.opcache
  • php83Extensions.opcache.dev
  • php83Extensions.openssl
  • php83Extensions.openssl.dev
  • php83Extensions.openswoole
  • php83Extensions.opentelemetry
  • php83Extensions.pcntl
  • php83Extensions.pcntl.dev
  • php83Extensions.pcov
  • php83Extensions.pdlib
  • php83Extensions.pdo
  • php83Extensions.pdo.dev
  • php83Extensions.pdo_dblib
  • php83Extensions.pdo_dblib.dev
  • php83Extensions.pdo_mysql
  • php83Extensions.pdo_mysql.dev
  • php83Extensions.pdo_oci
  • php83Extensions.pdo_odbc
  • php83Extensions.pdo_odbc.dev
  • php83Extensions.pdo_pgsql
  • php83Extensions.pdo_pgsql.dev
  • php83Extensions.pdo_sqlite
  • php83Extensions.pdo_sqlite.dev
  • php83Extensions.pdo_sqlsrv
  • php83Extensions.pgsql
  • php83Extensions.pgsql.dev
  • php83Extensions.phalcon
  • php83Extensions.pinba
  • php83Extensions.posix
  • php83Extensions.posix.dev
  • php83Extensions.protobuf
  • php83Extensions.pspell
  • php83Extensions.rdkafka
  • php83Extensions.readline
  • php83Extensions.readline.dev
  • php83Extensions.redis
  • php83Extensions.rrd
  • php83Extensions.session
  • php83Extensions.session.dev
  • php83Extensions.shmop
  • php83Extensions.shmop.dev
  • php83Extensions.simplexml
  • php83Extensions.simplexml.dev
  • php83Extensions.smbclient
  • php83Extensions.snmp
  • php83Extensions.snmp.dev
  • php83Extensions.snuffleupagus
  • php83Extensions.soap
  • php83Extensions.soap.dev
  • php83Extensions.sockets
  • php83Extensions.sockets.dev
  • php83Extensions.sodium
  • php83Extensions.sodium.dev
  • php83Extensions.spx
  • php83Extensions.sqlite3
  • php83Extensions.sqlite3.dev
  • php83Extensions.sqlsrv
  • php83Extensions.ssh2
  • php83Extensions.swoole
  • php83Extensions.sysvmsg
  • php83Extensions.sysvmsg.dev
  • php83Extensions.sysvsem
  • php83Extensions.sysvsem.dev
  • php83Extensions.sysvshm
  • php83Extensions.sysvshm.dev
  • php83Extensions.tidy
  • php83Extensions.tidy.dev
  • php83Extensions.tokenizer
  • php83Extensions.tokenizer.dev
  • php83Extensions.uv
  • php83Extensions.vld
  • php83Extensions.xdebug
  • php83Extensions.xml
  • php83Extensions.xml.dev
  • php83Extensions.xmlreader
  • php83Extensions.xmlreader.dev
  • php83Extensions.xmlwriter
  • php83Extensions.xmlwriter.dev
  • php83Extensions.xsl
  • php83Extensions.xsl.dev
  • php83Extensions.yaml
  • php83Extensions.zend_test
  • php83Extensions.zend_test.dev
  • php83Extensions.zip
  • php83Extensions.zip.dev
  • php83Extensions.zlib
  • php83Extensions.zlib.dev
  • php83Extensions.zstd
  • php83Packages.castor
  • php83Packages.composer
  • php83Packages.composer-local-repo-plugin
  • php83Packages.cyclonedx-php-composer
  • php83Packages.deployer
  • php83Packages.grumphp
  • php83Packages.phan
  • php83Packages.phing
  • php83Packages.phive
  • php83Packages.php-codesniffer
  • php83Packages.php-cs-fixer
  • php83Packages.php-parallel-lint
  • php83Packages.phpinsights
  • php83Packages.phpmd
  • php83Packages.phpspy
  • php83Packages.phpstan
  • php83Packages.psalm
  • phpactor
  • phpdocumentor
  • phpunit
  • pixelfed
  • pulseeffects-legacy
  • qcachegrind
  • roave-backward-compatibility-check
  • robo
  • rss-bridge-cli
  • signaturepdf
  • simplesamlphp
  • snipe-it
  • unit
  • vimPlugins.phpactor
  • weechat
  • weechat-unwrapped
  • weechat-unwrapped.guile
  • weechat-unwrapped.lua
  • weechat-unwrapped.man
  • weechat-unwrapped.perl
  • weechat-unwrapped.php
  • weechat-unwrapped.python
  • weechat-unwrapped.ruby
  • weechat-unwrapped.tcl
  • wp-cli
  • yle-dl
  • yle-dl.dist

Add a 👍 reaction to pull requests you find important.

Fixes CVE-2024-8927, CVE-2024-9026 and CVE-2024-8925.

Changes:
https://www.php.net/ChangeLog-8.php#8.1.30
Fixes CVE-2024-8927, CVE-2024-9026 and CVE-2024-8925.

Changes:
https://www.php.net/ChangeLog-8.php#8.2.24
Fixes CVE-2024-8927, CVE-2024-9026 and CVE-2024-8925.

Changes:
https://www.php.net/ChangeLog-8.php#8.3.12
@LeSuisse LeSuisse added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-24.05 labels Sep 27, 2024
@LeSuisse LeSuisse marked this pull request as ready for review September 27, 2024 21:00
@Ma27
Copy link
Member

Ma27 commented Sep 28, 2024

For ext-soap there's a patch to be reverted:

┃ error: build of '/nix/store/r6xav17zjizj5kby85d55fnk4m4fv4nv-php-soap-8.2.24.drv' on 'ssh-ng://tum-graham?&' failed: builder for '/nix/store/r6xav17zjizj5kby85d55fnk4m4fv4nv-php-soap-8.2.24.drv' failed with exit code 1;
┃        last 11 log lines:
┃        > Running phase: unpackPhase
┃        > unpacking source archive /nix/store/5fsvg108j89aivid9f6vs526fyf3gapq-php-8.2.24.tar.bz2
┃        > source root is php-8.2.24
┃        > setting SOURCE_DATE_EPOCH to timestamp 1727215960 of file php-8.2.24/win32/wsyslog.c
┃        > Running phase: patchPhase
┃        > applying patch /nix/store/vfmsv14ss5l89k63rlx0g6dcmvpbvrlk-1b52ecd78ad1a211a4a9db65975df34d2539125b.patch
┃        > patching file ext/soap/tests/bugs/bug55639.phpt
┃        > Reversed (or previously applied) patch detected!  Assume -R? [n]
┃        > Apply anyway? [n]
┃        > Skipping patch.
┃        > 1 out of 1 hunk ignored -- saving rejects to file ext/soap/tests/bugs/bug55639.phpt.rej
┃        For full logs, run 'nix log /nix/store/r6xav17zjizj5kby85d55fnk4m4fv4nv-php-soap-8.2.24.drv'.

Can take care of this in half an hour I guess.

This reverts commit bc9dacd.

Patch is now upstream.
@LeSuisse
Copy link
Contributor Author

Sorry I did revert it locally but forget to push the change after I tested it...

Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good on my end.

@Ma27
Copy link
Member

Ma27 commented Sep 28, 2024

Will merge when ofborg is green.

@ofborg ofborg bot requested review from Ma27 and piotrkwiecinski September 28, 2024 17:06
@drupol drupol merged commit 51c3426 into NixOS:master Sep 28, 2024
25 of 26 checks passed
Copy link
Contributor

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-344937-to-release-24.05 origin/release-24.05
cd .worktree/backport-344937-to-release-24.05
git switch --create backport-344937-to-release-24.05
git cherry-pick -x 27f1613fd0124ae2fdeb30689422e66f077dfe0d 922f9d74de207dc12fceb8ca3c7c108b7d39cfcb bb8164e2620ab83e4dbff753107be1af7c66d923 5c8b1b25bf33171b2cbd08dd248652049e802ae5

@drupol
Copy link
Contributor

drupol commented Sep 28, 2024

The backport is going to take some time. We need to backport everything that has been done since the last backport to 24.05. Anyone willing to help?

@Ma27
Copy link
Member

Ma27 commented Sep 28, 2024

I was about to do it now.

@drupol
Copy link
Contributor

drupol commented Sep 28, 2024

I started here: #345177 feel free to amend it !

@LeSuisse LeSuisse deleted the php-8.1.30-8.2.24-8.3.12 branch September 29, 2024 10:00
@domenkozar
Copy link
Member

@Ma27
Copy link
Member

Ma27 commented Oct 2, 2024

@domenkozar looking into it.

@Ma27
Copy link
Member

Ma27 commented Oct 2, 2024

Seems to be us this time fwiw:

========DIFF========
001- === Request with one cookie ===
002- POST / HTTP/1.1
003- Host: %s
004- Connection: Keep-Alive
005- User-Agent: PHP-SOAP/%s
006- Content-Type: text/xml; charset=utf-8
007- SOAPAction: "misc-uri#foo"
008- Content-Length: %d
009- Cookie: testcookie1=true
010- 
011- === Request with two cookies ===
012- POST / HTTP/1.1
013- Host: %s
014- Connection: Keep-Alive
015- User-Agent: PHP-SOAP/%s
016- Content-Type: text/xml; charset=utf-8
017- SOAPAction: "misc-uri#foo"
018- Content-Length: %d
019- Cookie: testcookie1=true; testcookie2=true
001+ Server failed to start
002+ Server output:
003+ [Wed Oct  2 08:58:23 2024] Failed to listen on localhost:0 (reason: php_network_getaddresses: getaddrinfo for localhost failed: nodename nor servname provided, or not known)
004+ <br />
005+ <b>Warning</b>:  Unknown: php_network_getaddresses: getaddrinfo for localhost failed: nodename nor servname provided, or not known in <b>Unknown</b> on line <b>0</b><br />
========DONE========

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants