Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-risczero: 0.17.0 -> 1.1.1 #345235

Closed
wants to merge 1 commit into from
Closed

Conversation

zimward
Copy link
Contributor

@zimward zimward commented Sep 29, 2024

Description of changes

Update also fixes failing build on rust 1.80 (#332957)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@momeemt
Copy link
Member

momeemt commented Sep 29, 2024

Result of nixpkgs-review pr 345235 run on aarch64-darwin 1

1 package failed to build:
  • cargo-risczero

@zimward zimward marked this pull request as draft September 30, 2024 00:58
@ocfox
Copy link
Member

ocfox commented Oct 2, 2024

why draft?

@zimward
Copy link
Contributor Author

zimward commented Oct 2, 2024

why draft?

build is currently failing in sandboxed builds as the build.rs downloads artifacts from AWS.

@zimward
Copy link
Contributor Author

zimward commented Nov 4, 2024

building this would require significant patches due to the build-time fetching of artifacts.

@zimward zimward closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants