Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chatterino7: init at 7.5.1 #345298

Closed
wants to merge 1 commit into from
Closed

Chatterino7: init at 7.5.1 #345298

wants to merge 1 commit into from

Conversation

hauskens
Copy link
Contributor

Description of changes

  • Added chatterino7, using same build as chatterino2 since it is a very similar fork
  • Added unstable build versions for chatterino2 and chatterino7
  • Added update script to support the unstable builds
  • Applied formatting
  • Added Hausken as maintainer
  • Added GIT_HASH environment variable during build so users can identify the version from Settings > About
  • Moved the stdenv logic from pkgs/top-level/all-packages.nix into the default.nix.

Hope it is fine the same maintainers is assigned for chatterino7 as for chatterino2.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@hauskens hauskens requested review from 0Supa and Aleksanaa September 29, 2024 13:47
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Sep 29, 2024
@ofborg ofborg bot requested a review from 0Supa September 29, 2024 14:53
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 29, 2024
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Sep 30, 2024
@hauskens
Copy link
Contributor Author

Hi @Aleksanaa , do you have any input on this one?

FliegendeWurst
FliegendeWurst reviewed Nov 1, 2024
View reviewed changes
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All packages build on x86_64 Linux

pkgs/applications/networking/instant-messengers/chatterino2/default.nix Outdated Show resolved Hide resolved
@FliegendeWurst
Copy link
Member

@ofborg build chatterino2 chatterino7

@wegank wegank removed 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 2, 2024
@ofborg ofborg bot requested a review from 0Supa November 2, 2024 16:22
@FliegendeWurst
Copy link
Member

@ofborg build chatterino2 chatterino7

@hauskens
Copy link
Contributor Author

@filakhtov Thanks for taking a look, I've applied your suggestions

@filakhtov
Copy link
Contributor

@hauskens I think you got the wrong guy 😅

@hauskens
Copy link
Contributor Author

@FliegendeWurst Thanks for taking a look, I've applied your suggestions

@FliegendeWurst
Copy link
Member

@ofborg bulid chatterino7

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Nov 28, 2024
@hauskens hauskens removed the request for review from Aleksanaa November 28, 2024 21:47
@hauskens
Copy link
Contributor Author

@0Supa Some small improvements was done to this PR since you last approved it, but i think we're good now.
Could you review the changes? I think this is ready for merge once approved

@0Supa
Copy link
Member

0Supa commented Dec 3, 2024

lgtm, tested

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2141

SuperSandro2000
SuperSandro2000 reviewed Dec 9, 2024
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not so hooked on that we are using so many vendored libraries

pkgs/applications/networking/instant-messengers/chatterino2/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/instant-messengers/chatterino2/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/instant-messengers/chatterino2/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/instant-messengers/chatterino2/default.nix Outdated Show resolved Hide resolved
@wegank wegank removed 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 10, 2024
@ofborg ofborg bot requested a review from 0Supa December 11, 2024 03:14
@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 15, 2024
@wegank wegank added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jan 4, 2025
@wegank
Copy link
Member

wegank commented Jan 6, 2025

Done in #371181.

@wegank wegank closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@0Supa 0Supa 0Supa approved these changes

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hauskens @FliegendeWurst @filakhtov @0Supa @nixos-discourse @wegank @SuperSandro2000