Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rhsrvany: init at 1.1 #345977

Merged
merged 2 commits into from
Oct 8, 2024
Merged

rhsrvany: init at 1.1 #345977

merged 2 commits into from
Oct 8, 2024

Conversation

lukts30
Copy link
Contributor

@lukts30 lukts30 commented Oct 2, 2024

Needed for virt-v2v for the conversions of Windows guests.
pkgs.pkgsCross.mingwW64.rhsrvany

https://github.com/rwmjones/rhsrvany

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 2, 2024
@apraga
Copy link
Contributor

apraga commented Oct 2, 2024

Result of nixpkgs-review pr 345977 run on x86_64-linux 1

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Oct 3, 2024
@lukts30
Copy link
Contributor Author

lukts30 commented Oct 3, 2024

qemu-img create -f qcow2 -b WinDev2404Eval.vhdx -o backing_fmt=vhdx overlay.qcow2

time virt-v2v-in-place -i disk ~/Downloads/vhdx/overlay.qcow2 
[   0.0] Setting up the source: -i disk /home/lukas/Downloads/vhdx/overlay.qcow2
[   1.0] Opening the source
[   4.1] Inspecting the source
[   6.0] Checking for sufficient free disk space in the guest
[   6.0] Converting Windows 10 Enterprise Evaluation to run on KVM
.virt-v2v-in-place-wrapped: This guest has virtio drivers installed.
[  10.3] Mapping filesystem data to avoid copying unused and blank areas
[  12.0] Closing the overlay
[  12.1] Assigning disks to buses
[  12.1] Checking if the guest needs BIOS or UEFI to boot
.virt-v2v-in-place-wrapped: This guest requires UEFI on the target to boot.
[  12.1] Finishing off

real    0m12,148s
user    0m9,569s
sys     0m7,511s         

I tested this locally with a working virt-v2v install. Both pnp_wait.exe & rhsrvany.exe are installed to "C:\Program Files\Guestfs\Firstboot" and the guest can be booted with virtio devices libvirt-v2v-win11.xml .
INACCESSIBLE_BOOT_DEVICE problem does not happen.

@lukts30 lukts30 marked this pull request as ready for review October 3, 2024 09:36
@lukts30 lukts30 requested a review from apraga October 3, 2024 10:01
This was referenced Oct 3, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 4, 2024
@bjornfor bjornfor merged commit 6322590 into NixOS:master Oct 8, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants