adjustor: init at 3.6.1

[toast003]

Adjustor is a plugin for handheld daemon that allows TDP control on AMD powered handhelds

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[alyraffauf]

This has been working well for me! Is there a reason it's still marked as a draft?

[toast003]

I still need to add an option to enable adjustor from services.handheld-daemon, plus I also noticed some weirdness with ppd emulation.

Iirc power profiles would only apply when you changed the tdp, as well as some errors showing up.

[toast003]

I'm not sure how to tackle adjustor's energy management feature, since it does different things depending on the hardware you run it on.

On handhelds it emulates power-profiles-daemon, while on everything else it uses it. Since there's no way to only disable energy management without disabling TDP control entirely, right now I think the thing to do is add an option (adjustor.energyManagement) that disables ppd when enabled, and assures handheld-daemon starts after ppd when disabled. That way we'll avoid conflicting with ppd unless the user wants to use the energy management feature.

EDIT: Energy management can be disabled separately, very first option too so I'm not sure how I missed it 😅

[alyraffauf]

This seems like a good solution, it ought to also conflict with tuned (not yet merged into nixpkgs) and other power management daemons.

Looking into Bazzite, Bazzite masks tuned on handhelds that use adjustor, while it's unmasked on laptops and other devices. Adjustor is only installed on handhelds afaict. I know they have plans for other types of devices but for now it seems like everyone is using tuned or PPD.

[alyraffauf]

Also, iirc PPD emulation is an option within the HHD UI, not sure how that factors in here but it seems optional.

[toast003]

Yeah, PPD emulation can be turned off as well as energy management, which I missed initially.

Looking into Bazzite, Bazzite masks tuned on handhelds that use adjustor, while it's unmasked on laptops and other devices. Adjustor is only installed on handhelds afaict. I know they have plans for other types of devices but for now it seems like everyone is using tuned or PPD.

Adjustor does have some logic to deal with this with HHD_PPD_MASK, however it involves masking ppd and tuned, which we can't do on NixOS. Apart from some nasty looking errors from systemctl it does work tho, so that's probably the way foward.