Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/linkwarden: init module, linkwarden: init at 2.9.2 #347353

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

nixos/linkwarden: init module, linkwarden: init at 2.9.2 #347353

wants to merge 4 commits into from
+403 −1

Conversation

jvanbruegge
Copy link
Contributor

Linkwarden is a self-hosted bookmarks manager: https://linkwarden.app/

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 8, 2024
@jvanbruegge jvanbruegge force-pushed the linkwarden branch 2 times, most recently from 53fb536 to 73ed656 Compare October 8, 2024 21:36
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 8, 2024
@jvanbruegge jvanbruegge force-pushed the linkwarden branch 3 times, most recently from c68a697 to 75c84ce Compare October 9, 2024 14:27
@h7x4 h7x4 added 8.has: module (new) This PR adds a module in `nixos/` 8.has: tests This PR has tests labels Oct 10, 2024
@jvanbruegge jvanbruegge mentioned this pull request Oct 25, 2024
Draft
13 tasks
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 1, 2024
@jvanbruegge jvanbruegge force-pushed the linkwarden branch 2 times, most recently from 3df49a6 to aa7a032 Compare November 13, 2024 23:13
@jvanbruegge
Copy link
Contributor Author

I've updated this PR now to the new version of linkwarden which does not need patching any more (all my PRs have been merged)

@jvanbruegge jvanbruegge removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 13, 2024
@jvanbruegge
Copy link
Contributor Author

Just updated my own linkwarden instance and everything works as expected

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 14, 2024
@jvanbruegge jvanbruegge removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 14, 2024
@jvanbruegge jvanbruegge changed the title nixos/linkwarden: init module, linkwarden: init at 2.7.1 nixos/linkwarden: init module, linkwarden: init at 2.8.1 Nov 14, 2024
@74k1
Copy link
Contributor

74k1 commented Nov 14, 2024 •
edited
Loading

Nice, builds & works as expected again! LGTM

@anpandey
Copy link
Contributor

anpandey commented Dec 2, 2024

I've been using the module in this PR for the past few weeks without issue - would love to see this merged.

@jvanbruegge
Copy link
Contributor Author

I've updated this PR now to the newest version of linkwarden

@jvanbruegge jvanbruegge changed the title nixos/linkwarden: init module, linkwarden: init at 2.8.1 nixos/linkwarden: init module, linkwarden: init at 2.8.4 Dec 23, 2024
@jvanbruegge jvanbruegge force-pushed the linkwarden branch 3 times, most recently from dbb9fca to 3d97e49 Compare December 29, 2024 15:40
@jvanbruegge
Copy link
Contributor Author

@dotlambda would it be possible to merge this? It has been sitting forever now. I am actively using the module from this PR without any issues

@jvanbruegge jvanbruegge force-pushed the linkwarden branch 2 times, most recently from a4bdbb9 to dc248a8 Compare January 6, 2025 11:10
@jvanbruegge jvanbruegge changed the title nixos/linkwarden: init module, linkwarden: init at 2.8.4 nixos/linkwarden: init module, linkwarden: init at 2.9.0 Jan 6, 2025
@jvanbruegge
Copy link
Contributor Author

10min ago, version 2.9.0 was released. I have updated the PR to the new version

@jvanbruegge jvanbruegge changed the title nixos/linkwarden: init module, linkwarden: init at 2.9.0 nixos/linkwarden: init module, linkwarden: init at 2.9.2 Jan 7, 2025
@jvanbruegge
Copy link
Contributor Author

Updated to 2.9.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weriomat weriomat weriomat left review comments

@74k1 74k1 74k1 left review comments

@reo101 reo101 reo101 left review comments

@FMGordillo FMGordillo FMGordillo left review comments

@B4dM4n B4dM4n B4dM4n left review comments

@h3ndrik h3ndrik h3ndrik left review comments

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 8.has: tests This PR has tests 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@jvanbruegge @74k1 @anpandey @h3ndrik @B4dM4n @FMGordillo @reo101 @weriomat @wegank @h7x4