-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cider-2: init at 2.5.0 #347363
Merged
Merged
cider-2: init at 2.5.0 #347363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
8.has: maintainer-list (update)
This PR changes `maintainers/maintainer-list.nix`
label
Oct 8, 2024
NixOSInfra
added
the
12. first-time contribution
This PR is the author's first one; please be gentle!
label
Oct 8, 2024
itsvic-dev
force-pushed
the
cider-2-init
branch
from
October 8, 2024 23:10
eafbda8
to
a09ddb1
Compare
moved the package definition to pkgs/by-name as suggested by nixpkgs-vet. |
ofborg
bot
added
8.has: package (new)
This PR adds a new package
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
Oct 9, 2024
Aleksanaa
reviewed
Oct 27, 2024
itsvic-dev
force-pushed
the
cider-2-init
branch
from
October 30, 2024 20:30
a09ddb1
to
347cac9
Compare
itsvic-dev
force-pushed
the
cider-2-init
branch
from
October 30, 2024 20:32
347cac9
to
91821f6
Compare
applied the suggestions and rebased to latest master (71ccc3b) |
I'd assume it works on your end. Please verify it still works. |
indeed it does still work, resulting in store path |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
8.has: maintainer-list (update)
This PR changes `maintainers/maintainer-list.nix`
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
10.rebuild-linux: 1
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
12. first-time contribution
This PR is the author's first one; please be gentle!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cider 2 is a third-party client for Apple Music, available for purchase via itch.io and Microsoft Store (Windows-only).
https://cider.sh/
(sorry about accidentally touching the formatting of another maintainer's keys, I have autoformatting enabled in my code editor)
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.