Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.mygene: init at 3.2.2 #347629

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

rayhem
Copy link
Member

@rayhem rayhem commented Oct 10, 2024

Resolves #344328

Introduces mygene as an available python library to use in gene analysis.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@nix-owners nix-owners bot requested a review from natsukium October 10, 2024 01:22
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 10, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 31, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4823

pkgs/development/python-modules/mygene/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/mygene/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/mygene/default.nix Outdated Show resolved Hide resolved
@FliegendeWurst
Copy link
Member

Please squash commits and drop the merge commit (rebase instead).

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 14, 2024
@rayhem rayhem requested a review from natsukium November 21, 2024 21:43
@FliegendeWurst
Copy link
Member

Please squash and rebase on master.

Resolves NixOS#344328

Update pkgs/development/python-modules/mygene/default.nix

Co-authored-by: OTABI Tomoya <[email protected]>

Update pkgs/development/python-modules/mygene/default.nix

Co-authored-by: OTABI Tomoya <[email protected]>

Update pkgs/development/python-modules/mygene/default.nix

Co-authored-by: OTABI Tomoya <[email protected]>

Use optional-dependencies

Update tests for mygene
@rayhem
Copy link
Member Author

rayhem commented Nov 25, 2024

Sorry for the noise @FliegendeWurst - I'm not the most familiar with git(hub; I mostly use perforce in my day-to-day). None of my logs locally showed the merge commit and pulling reported everything as up-to-date; I don't know why it persisted in this PR, but another force push to sync everything seems to have squashed correctly.

@FliegendeWurst
Copy link
Member

FliegendeWurst commented Nov 25, 2024

I think there is a button on Github that will create a merge commit. It is called "sync" or something.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 26, 2024
@FliegendeWurst FliegendeWurst merged commit 1858008 into NixOS:master Dec 19, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: MyGene.py
5 participants