gnuradio3_8: fix build #348477
Closed
gnuradio3_8: fix build #348477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doronbehar
requested changes
Oct 18, 2024
There was a problem hiding this comment.
Hello and thanks for making an effort to fix this :). Due to the qwt passthru inherit, ofborg evaluation failed and I wasn't called for a review by ofborg. I will fix these issues in #349079 which already triggers a rebuild of gnuradio.
| @@ -268,7 +268,7 @@ stdenv.mkDerivation (finalAttrs: (shared // { | |||
| } // lib.optionalAttrs (hasFeature "gr-uhd") { | |||
| inherit uhd; | |||
| } // lib.optionalAttrs (hasFeature "gr-qtgui") { | |||
| inherit (libsForQt5) qwt; | |||
| inherit (libsForQt5) qwt6_1; | |||
There was a problem hiding this comment.
Suggested change
| inherit (libsForQt5) qwt6_1; | |
| qwt = qwt6_1; |
Comment on lines
+48
to
+57
| swig3 = ((swig.overrideAttrs (old: rec { | ||
| version = "3.0.12"; | ||
| src = fetchFromGitHub { | ||
| owner = "swig"; | ||
| repo = "swig"; | ||
| rev = "rel-${version}"; | ||
| sha256 = "1wyffskbkzj5zyhjnnpip80xzsjcr3p0q5486z3wdwabnysnhn8n"; | ||
| }; | ||
| })).override | ||
| { pcre2 = pcre; }); |
There was a problem hiding this comment.
Aish, swig3 was just dropped in bfab6b0f8386 (#341384) . How did you conclude that swig3 is needed? I just built it locally without this swig3 commit.
| @@ -83,7 +95,7 @@ let | |||
| python-support = { | |||
| pythonRuntime = [ python.pkgs.six ]; | |||
| native = [ | |||
| swig | |||
| swig3 | |||
There was a problem hiding this comment.
This also requires changing the swig that is passed to the gnuradio3_8Packages...
|
Closed in favor of #349079 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gnuradio3_8 package currently fails to build because of an incompatible qwt version:
This change introduced the issue: #312289
Using qwt6_1 instead fixes this Problem
A recent upgrade of the swig package from swig3 to swig4 (#337624) also introduced issues resulting in the package tests not running correctly.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.