Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jaxlib: update cudaSupport hash #348883

Closed
wants to merge 1 commit into from
Closed

jaxlib: update cudaSupport hash #348883

wants to merge 1 commit into from

Conversation

nixupp
Copy link
Contributor

@nixupp nixupp commented Oct 15, 2024 •
edited
Loading

Just updated the hash.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@bmillwood
Copy link
Contributor

Looks like the CI is upset that this isn't targeting master.

Also is it just #321920 again? (I'm not very familiar with this stuff, this is just from searching for issues and PRs)

@SomeoneSerge SomeoneSerge added the 6.topic: cuda Parallel computing platform and API label Oct 20, 2024
@hexlic
Copy link

hexlic commented Oct 21, 2024 •
edited
Loading

Yes, the "cause of repruducibility" issue and this PR are targeting the same problem.

I do not know the cause of this nor do I have the time to research this :(.
All I know that is that it was reported in #347928 and #346686.
I saw no action taken by the maintainer so I have decided to update the hash myself.

I really need this for my system to work. That's why I have decided to just update the hash.

Also, what should I target?

@bmillwood
Copy link
Contributor

Also, what should I target?

The full doc is here but the short version is that you target master, then once that's merged, you copy the PR to release-24.05, which (AIUI) Hydra will then update nixos-24.05 to include when CI is happy.

That said, whether this PR is a good idea or not depends on the nature of the nondeterminism, right? If it's the case that some builds get hash A and some get hash B, then switching the hash from A to B doesn't really solve anything -- you'll break as many people as you fix. On the other hand, from reading the other thread, maybe it's something like: there's an external dependency that changes over time, so the hash that everyone gets keeps changing, but at least it's the same hash for everyone? In which case this PR doesn't fully solve the problem but at least buys us more time?

In the meantime, do you already know how to use a nixpkgs branch / set up a local package so that you can work around this problem yourself even if it isn't merged (yet)?

@tomodachi94 tomodachi94 changed the base branch from nixos-24.05 to master October 28, 2024 06:46
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: qt/kde 6.topic: kernel The Linux kernel 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: printing 6.topic: rust 6.topic: policy discussion 6.topic: golang 6.topic: ruby 6.topic: vim 6.topic: ocaml 6.topic: fetch 6.topic: steam Steam game store/launcher (store.steampowered.com) 6.topic: stdenv Standard environment 6.topic: nodejs 6.topic: pantheon The Pantheon desktop environment 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: lua labels Oct 28, 2024
@github-actions github-actions bot removed 6.topic: ruby 6.topic: vim 6.topic: ocaml 6.topic: fetch 6.topic: steam Steam game store/launcher (store.steampowered.com) 6.topic: stdenv Standard environment 6.topic: nodejs 6.topic: pantheon The Pantheon desktop environment 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: lua 6.topic: testing Tooling for automated testing of packages and modules 6.topic: systemd 6.topic: LXQt The Lightweight Qt Desktop Environment 6.topic: vscode 6.topic: flakes The experimental Nix feature 6.topic: lib The Nixpkgs function library 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: julia 6.topic: php 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: k3s Kubernates distribution (https://k3s.io/) labels Oct 28, 2024
@tomodachi94 tomodachi94 added 6.topic: python 6.topic: cuda Parallel computing platform and API and removed 6.topic: python 6.topic: cuda Parallel computing platform and API 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: dotnet Language: .NET labels Oct 28, 2024
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 28, 2024
@wegank
Copy link
Member

wegank commented Dec 31, 2024

This PR is closed as part of the NixOS 24.05 EOL Cleanup: https://nixos.github.io/release-wiki/EOL-Cleanup.html

@wegank wegank closed this Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: cuda Parallel computing platform and API 6.topic: python
Projects
CUDA Team
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nixupp @bmillwood @hexlic @wegank @SomeoneSerge @tomodachi94