opentelemetry-collector-builder: 0.101.0 -> 0.112.0 #350795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
11.by: package-maintainer
FliegendeWurst
requested changes
Oct 30, 2024
There was a problem hiding this comment.
Build fails
--- FAIL: TestReplaceStatementsAreComplete (0.02s)
main_test.go:469:
Error Trace: /build/source/cmd/builder/internal/builder/main_test.go:469
Error: Received unexpected error:
failed to update go.mod: go subcommand failed with args '[mod tidy -compat=1.22]': exit status 1, error message: go: github.com/knadh/koanf/providers/[email protected]: reading file:///nix/store/sfb5rm8182fjzfray23n61jwyq6vbf6k-ocb-0.112.0-go-modules/github.com/knadh/koanf/providers/confmap/@v/v0.1.0.mod: no such file or directory
Test: TestReplaceStatementsAreComplete
FAIL
FAIL go.opentelemetry.io/collector/cmd/builder/internal/builder 0.100s
FAIL
|
|
||
| src = fetchFromGitHub { | ||
| owner = "open-telemetry"; | ||
| repo = "opentelemetry-collector"; | ||
| rev = "cmd/builder/v${version}"; | ||
| hash = "sha256-Ucp00OjyPtHA6so/NOzTLtPSuhXwz6A2708w2WIZb/E="; | ||
| sha256 = "sha256-Ucp00OjyPtHA6so/NOzTLtPSuhXwz6A2708w2WIZb/E="; | ||
| }; | ||
|
|
||
| sourceRoot = "${src.name}/cmd/builder"; |
There was a problem hiding this comment.
vendorHash should be sha256-vZsGSLdzKa4sA/N3RG6Kwn8tMoIIhPJ6uAkM4pheitU=
There was a problem hiding this comment.
Hey, sorry I was building successfully with the earlier setup, perhaps I forgot to ignore cached results or something. Thanks for the heads up.
FliegendeWurst
requested changes
Oct 31, 2024
There was a problem hiding this comment.
Still fails to build when rebased on master
--- FAIL: TestReplaceStatementsAreComplete (0.02s)
main_test.go:469:
Error Trace: /build/source/cmd/builder/internal/builder/main_test.go:469
Error: Received unexpected error:
failed to update go.mod: go subcommand failed with args '[mod tidy -compat=1.22]': exit status 1, error message: go: github.com/knadh/koanf/[email protected]: module lookup disabled by GOPROXY=off
Test: TestReplaceStatementsAreComplete
FAIL
FAIL go.opentelemetry.io/collector/cmd/builder/internal/builder 0.093s
FAIL
github-actions
bot
added
6.topic: python
6.topic: nixos
github-actions
bot
removed
6.topic: emacs
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.