Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spotlight-downloader: init at 1.5.0 #351095

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

UlyssesZh
Copy link
Member

Adds package spotlight-downloader. Website. Installs command SpotlightDownloader.

I didn't use buildDotnetModule because I need to use msbuild.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@KiaraGrouwstra
Copy link
Contributor

Result of nixpkgs-review pr 351095 run on x86_64-linux 1

1 package built:
  • spotlight-downloader

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2109

@UlyssesZh UlyssesZh force-pushed the spotlight-downloader branch from 731fb88 to 4d6da31 Compare November 24, 2024 18:51
@UlyssesZh UlyssesZh force-pushed the spotlight-downloader branch from 4d6da31 to bdc67de Compare December 6, 2024 06:45
@FliegendeWurst FliegendeWurst merged commit 665b621 into NixOS:master Dec 12, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants