Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flutter327: init; flutterPackages-source.v3_26: fix source; flutter324: 3.24.3 -> 3.24.4 #351189

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

RossComputerGuy
Copy link
Member

Things done

Fixes Flutter 3.26 for the source built engine, updates Flutter 3.24, and adds Flutter 3.27.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@FlafyDev
Copy link
Contributor

Result of nixpkgs-review pr 351189 run on x86_64-linux 1

5 packages marked as broken and skipped:
  • fluffychat
  • fluffychat-web
  • fluffychat-web.pubcache
  • fluffychat.debug
  • fluffychat.pubcache
6 packages failed to build:
  • flutterPackages-source.beta (flutterPackages-source.v3_27)
  • flutterPackages-source.v3_24 (flutterPackages-source.stable)
  • flutterPackages-source.v3_26
  • quickgui
  • quickgui.debug
  • quickgui.pubcache
32 packages built:
  • ente-auth
  • ente-auth.debug
  • ente-auth.pubcache
  • finamp
  • finamp.debug
  • finamp.pubcache
  • firmware-updater
  • firmware-updater.debug
  • firmware-updater.pubcache
  • flet-client-flutter
  • flet-client-flutter.debug
  • flet-client-flutter.pubcache
  • flutter (flutter324 ,flutterPackages-bin.stable ,flutterPackages-bin.v3_24 ,flutterPackages.stable ,flutterPackages.v3_24)
  • flutter327 (flutterPackages-bin.beta ,flutterPackages-bin.v3_27 ,flutterPackages.beta ,flutterPackages.v3_27)
  • hover
  • localsend
  • localsend.debug
  • localsend.pubcache
  • musicpod
  • musicpod.debug
  • musicpod.pubcache
  • python311Packages.flet
  • python311Packages.flet-runtime
  • python311Packages.flet-runtime.dist
  • python311Packages.flet.dist
  • python312Packages.flet
  • python312Packages.flet-runtime
  • python312Packages.flet-runtime.dist
  • python312Packages.flet.dist
  • yubioath-flutter
  • yubioath-flutter.debug
  • yubioath-flutter.pubcache

@RossComputerGuy
Copy link
Member Author

I fixed the first 3 broken packages, quickgui I can't build because I'm on aarch64-linux.

@FlafyDev
Copy link
Contributor

quickgui doesn't build in master https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.quickgui.x86_64-linux. so it's fine that it fails

flutterPackages-source.* still fail in x86_64-linux. seems to be because of wrong hashes

Result of nixpkgs-review pr 351189 run on x86_64-linux 1

6 packages failed to build:
  • flutterPackages-source.beta
  • flutterPackages-source.stable
  • flutterPackages-source.v3_26
  • quickgui
  • quickgui.debug
  • quickgui.pubcache
32 packages built:
  • ente-auth
  • ente-auth.debug
  • ente-auth.pubcache
  • finamp
  • finamp.debug
  • finamp.pubcache
  • firmware-updater
  • firmware-updater.debug
  • firmware-updater.pubcache
  • flet-client-flutter
  • flet-client-flutter.debug
  • flet-client-flutter.pubcache
  • flutter
  • flutter327
  • hover
  • localsend
  • localsend.debug
  • localsend.pubcache
  • musicpod
  • musicpod.debug
  • musicpod.pubcache
  • python311Packages.flet
  • python311Packages.flet-runtime
  • python311Packages.flet-runtime.dist
  • python311Packages.flet.dist
  • python312Packages.flet
  • python312Packages.flet-runtime
  • python312Packages.flet-runtime.dist
  • python312Packages.flet.dist
  • yubioath-flutter
  • yubioath-flutter.debug
  • yubioath-flutter.pubcache

@RossComputerGuy
Copy link
Member Author

flutterPackages-source.* still fail in x86_64-linux. seems to be because of wrong hashes

aarch64-linux doesn't get wrong hashes.

@RossComputerGuy RossComputerGuy merged commit 7608f64 into NixOS:master Oct 28, 2024
27 of 28 checks passed
@RossComputerGuy RossComputerGuy deleted the feat/flutter-update branch October 28, 2024 22:45
@RossComputerGuy
Copy link
Member Author

A follow up PR will resolve the problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants