Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sshified: init at 1.2.1 #351532

Merged
merged 2 commits into from
Oct 27, 2024
Merged

sshified: init at 1.2.1 #351532

merged 2 commits into from
Oct 27, 2024

Conversation

joinemm
Copy link
Contributor

@joinemm joinemm commented Oct 26, 2024

https://github.com/hoffie/sshified is a http proxy that tunnels requests through ssh connections.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Oct 26, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Oct 26, 2024
fabaff
fabaff reviewed Oct 27, 2024
View reviewed changes
pkgs/by-name/ss/sshified/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ss/sshified/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ss/sshified/package.nix Show resolved Hide resolved
@joinemm
Copy link
Contributor Author

joinemm commented Oct 27, 2024

@fabaff @Aleksanaa Thanks, added your suggested changes.

@Aleksanaa
Copy link
Member

built on aarch64-darwin

@Aleksanaa Aleksanaa merged commit 2f6fc5a into NixOS:master Oct 27, 2024
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff left review comments

@Aleksanaa Aleksanaa Aleksanaa approved these changes

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joinemm @Aleksanaa @fabaff @NixOSInfra