factorio: use real instead of sample in download help; warn about credentials in store #351555
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
amarshall
force-pushed
the
factorio-fetch-help
branch
from
2a4b23e to
2305d3d
Compare
amarshall
force-pushed
the
factorio-fetch-help
branch
from
2305d3d to
b01332a
Compare
pkgs/by-name/fa/factorio/package.nix
Outdated
| ]; | ||
| system.extraDependencies = [ | ||
| factorio.src | ||
| ]; | ||
| ''; |
There was a problem hiding this comment.
| ''; | |
| ''; |
this should make nixfmt CI pass I think
though, if you make other changes too, probably just want to run nixfmt yourself, here are the instructions from the failing check step:
pkgs/by-name/fa/factorio/package.nix: not formatted
Some new/changed Nix files are not properly formatted
Please go to the Nixpkgs root directory, run `nix-shell`, then:
nixfmt 'pkgs/by-name/fa/factorio/package.nix'
If you're having trouble, please ping [redacted, just in case @-pings work inside code blocks]
pkgs/by-name/fa/factorio/package.nix
Outdated
|
|
||
| Note the ultimate "_" is replaced with "-" in the --name arg! | ||
| Note the ultimate "_" is replaced with "-" in the --name arg! |
There was a problem hiding this comment.
it's slightly awkward that we can no longer guarantee that this is true (or the only difference). I think it's acceptable to leave it as it is, but perhaps there's a rephrasing that is more accurate?
There was a problem hiding this comment.
Perhaps it doesn’t matter so much to call this out now that folks should be able to just copy-paste as-is rather than bother manually munging the names.
There was a problem hiding this comment.
yeah, I'm on board with getting rid of it entirely (though I'm not a maintainer or anything, so my opinion has no special weight :) )
|
wegank
added
the
12.approvals: 1
amarshall
force-pushed
the
factorio-fetch-help
branch
from
b01332a to
f2c8cc4
Compare
Makes it easier for the user since they should no longer have to manually replace things. Remove the note about the name as it may no longer be true, and the user now has to care less since the values are more easily copy-pastable.
amarshall
force-pushed
the
factorio-fetch-help
branch
from
f2c8cc4 to
5c358db
Compare
|
Rebased and fixed nixfmt errors. |
|
|
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.