-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
texlive: 2023-final -> 2024.20241027 #351790
Conversation
@@ -126,6 +126,11 @@ in lib.recursiveUpdate orig rec { | |||
"mtxrun.lua" = tl.context.tex + "/scripts/context/lua/mtxrun.lua"; | |||
}; | |||
|
|||
context-legacy.binlinks = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why, but "ctxtools" and "pstopdf" are not in context-legacy.binfiles
. I wasn't sure if we are supposed to still provide them or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears they are not in TeX Live anymore, so that's fine.
Thanks for the speedy PR! I just applied texlive 2024 to my nix-darwin config and it worked without any issues. I can also confirm that my issue with I tried to run nixpkgs-review pr 351790error:
… while querying the derivation named 'manim-0.18.1'
… while calling the 'getAttr' builtin
at <nix/derivation-internal.nix>:44:19:
43| value = commonAttrs // {
44| outPath = builtins.getAttr outputName strict;
| ^
45| drvPath = strict.drvPath;
… while calling the 'derivationStrict' builtin
at <nix/derivation-internal.nix>:34:12:
33|
34| strict = derivationStrict drvAttrs;
| ^
35|
… while evaluating derivation 'python3.12-manim-0.18.1'
whose name attribute is located at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:336:7
… while evaluating attribute '__impureHostDeps' of derivation 'python3.12-manim-0.18.1'
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:451:7:
450| __propagatedSandboxProfile = unique (computedPropagatedSandboxProfile ++ [ propagatedSandboxProfile ]);
451| __impureHostDeps = computedImpureHostDeps ++ computedPropagatedImpureHostDeps ++ __propagatedImpureHostDeps ++ __impureHostDeps ++ stdenv.__extraImpureHostDeps ++ [
| ^
452| "/dev/zero"
… while calling the 'foldl'' builtin
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:435:11:
434| computedImpureHostDeps =
435| unique (concatMap (input: input.__propagatedImpureHostDeps or [])
| ^
436| (stdenv.extraNativeBuildInputs
… while calling the 'concatMap' builtin
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:435:19:
434| computedImpureHostDeps =
435| unique (concatMap (input: input.__propagatedImpureHostDeps or [])
| ^
436| (stdenv.extraNativeBuildInputs
… while calling anonymous lambda
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:435:30:
434| computedImpureHostDeps =
435| unique (concatMap (input: input.__propagatedImpureHostDeps or [])
| ^
436| (stdenv.extraNativeBuildInputs
… from call site
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:435:37:
434| computedImpureHostDeps =
435| unique (concatMap (input: input.__propagatedImpureHostDeps or [])
| ^
436| (stdenv.extraNativeBuildInputs
… while calling anonymous lambda
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:307:13:
306| (map (drv: getDev drv.__spliced.buildBuild or drv) (checkDependencyList "depsBuildBuild" depsBuildBuild))
307| (map (drv: getDev drv.__spliced.buildHost or drv) (checkDependencyList "nativeBuildInputs" nativeBuildInputs'))
| ^
308| (map (drv: getDev drv.__spliced.buildTarget or drv) (checkDependencyList "depsBuildTarget" depsBuildTarget))
… from call site
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:307:18:
306| (map (drv: getDev drv.__spliced.buildBuild or drv) (checkDependencyList "depsBuildBuild" depsBuildBuild))
307| (map (drv: getDev drv.__spliced.buildHost or drv) (checkDependencyList "nativeBuildInputs" nativeBuildInputs'))
| ^
308| (map (drv: getDev drv.__spliced.buildTarget or drv) (checkDependencyList "depsBuildTarget" depsBuildTarget))
… while calling 'getOutput'
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/attrsets.nix:1797:23:
1796| */
1797| getOutput = output: pkg:
| ^
1798| if ! pkg ? outputSpecified || ! pkg.outputSpecified
… while evaluating a branch condition
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/attrsets.nix:1798:5:
1797| getOutput = output: pkg:
1798| if ! pkg ? outputSpecified || ! pkg.outputSpecified
| ^
1799| then pkg.${output} or pkg.out or pkg
… in the left operand of the OR (||) operator
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/attrsets.nix:1798:32:
1797| getOutput = output: pkg:
1798| if ! pkg ? outputSpecified || ! pkg.outputSpecified
| ^
1799| then pkg.${output} or pkg.out or pkg
… in the argument of the not operator
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/attrsets.nix:1798:10:
1797| getOutput = output: pkg:
1798| if ! pkg ? outputSpecified || ! pkg.outputSpecified
| ^
1799| then pkg.${output} or pkg.out or pkg
… from call site
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:307:25:
306| (map (drv: getDev drv.__spliced.buildBuild or drv) (checkDependencyList "depsBuildBuild" depsBuildBuild))
307| (map (drv: getDev drv.__spliced.buildHost or drv) (checkDependencyList "nativeBuildInputs" nativeBuildInputs'))
| ^
308| (map (drv: getDev drv.__spliced.buildTarget or drv) (checkDependencyList "depsBuildTarget" depsBuildTarget))
… while calling anonymous lambda
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/lists.nix:334:29:
333| */
334| imap1 = f: list: genList (n: f (n + 1) (elemAt list n)) (length list);
| ^
335|
… from call site
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/lists.nix:334:32:
333| */
334| imap1 = f: list: genList (n: f (n + 1) (elemAt list n)) (length list);
| ^
335|
… while calling anonymous lambda
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:281:15:
280| imap1
281| (index: dep:
| ^
282| if isDerivation dep || dep == null || builtins.isString dep || builtins.isPath dep then dep
… while evaluating a branch condition
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:282:9:
281| (index: dep:
282| if isDerivation dep || dep == null || builtins.isString dep || builtins.isPath dep then dep
| ^
283| else if isList dep then checkDependencyList' ([index] ++ positions) name dep
… in the left operand of the OR (||) operator
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:282:69:
281| (index: dep:
282| if isDerivation dep || dep == null || builtins.isString dep || builtins.isPath dep then dep
| ^
283| else if isList dep then checkDependencyList' ([index] ++ positions) name dep
… in the left operand of the OR (||) operator
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:282:44:
281| (index: dep:
282| if isDerivation dep || dep == null || builtins.isString dep || builtins.isPath dep then dep
| ^
283| else if isList dep then checkDependencyList' ([index] ++ positions) name dep
… in the left operand of the OR (||) operator
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:282:29:
281| (index: dep:
282| if isDerivation dep || dep == null || builtins.isString dep || builtins.isPath dep then dep
| ^
283| else if isList dep then checkDependencyList' ([index] ++ positions) name dep
… from call site
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:282:12:
281| (index: dep:
282| if isDerivation dep || dep == null || builtins.isString dep || builtins.isPath dep then dep
| ^
283| else if isList dep then checkDependencyList' ([index] ++ positions) name dep
… while calling 'isDerivation'
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/attrsets.nix:1283:5:
1282| isDerivation =
1283| value: value.type or null == "derivation";
| ^
1284|
… while calling the 'elemAt' builtin
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/lists.nix:334:43:
333| */
334| imap1 = f: list: genList (n: f (n + 1) (elemAt list n)) (length list);
| ^
335|
… from call site
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/development/python-modules/manim/default.nix:55:19:
54| # these two combined add up to:
55| manim-tinytex = texliveInfraOnly.withPackages (
| ^
56| ps: with ps; [
… while calling 'withPackages'
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:213:20:
212| self (args // { __fromCombineWrapper = false; } // appliedArgs);
213| withPackages = reqs: self (args // { requiredTeXPackages = ps: reqs ps ++ requiredTeXPackages ps; __fromCombineWrapper = false; });
| ^
214| };
… from call site
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:213:26:
212| self (args // { __fromCombineWrapper = false; } // appliedArgs);
213| withPackages = reqs: self (args // { requiredTeXPackages = ps: reqs ps ++ requiredTeXPackages ps; __fromCombineWrapper = false; });
| ^
214| };
… while calling anonymous lambda
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:26:16:
25|
26| lib.fix (self: {
| ^
27| withDocs ? false
… from call site
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:315:54:
314| # outputsToInstall must be set *after* overrideAttrs (used in buildEnv') or it fails the checkMeta tests
315| in if __combine || __formatsOf != null then out else lib.addMetaAttrs { inherit (pkgList) outputsToInstall; } out)
| ^
316|
… while calling 'addMetaAttrs'
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/meta.nix:42:28:
41| */
42| addMetaAttrs = newAttrs: drv:
| ^
43| drv // { meta = (drv.meta or {}) // newAttrs; };
… in the left operand of the update (//) operator
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/meta.nix:43:9:
42| addMetaAttrs = newAttrs: drv:
43| drv // { meta = (drv.meta or {}) // newAttrs; };
| ^
44|
… from call site
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:260:1:
259| # no indent for git diff purposes
260| buildEnv' {
| ^
261|
… while calling 'buildEnv''
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:44:15:
43| ### buildEnv with custom attributes
44| buildEnv' = args: (buildEnv
| ^
45| ({ inherit (args) name paths; })
… from call site
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:44:21:
43| ### buildEnv with custom attributes
44| buildEnv' = args: (buildEnv
| ^
45| ({ inherit (args) name paths; })
… while calling 'overrideAttrs'
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/customisation.nix:152:73:
151| overrideDerivation = fdrv: overrideResult (x: overrideDerivation x fdrv);
152| ${if result ? overrideAttrs then "overrideAttrs" else null} = fdrv:
| ^
153| overrideResult (x: x.overrideAttrs fdrv);
… from call site
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/customisation.nix:153:13:
152| ${if result ? overrideAttrs then "overrideAttrs" else null} = fdrv:
153| overrideResult (x: x.overrideAttrs fdrv);
| ^
154| }
… while calling 'overrideResult'
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/customisation.nix:146:24:
145| # Change the result of the function call by applying g to it
146| overrideResult = g: makeOverridable (mirrorArgs (args: g (f args))) origArgs;
| ^
147| in
… while calling a functor (an attribute set with a '__functor' attribute)
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/customisation.nix:146:27:
145| # Change the result of the function call by applying g to it
146| overrideResult = g: makeOverridable (mirrorArgs (args: g (f args))) origArgs;
| ^
147| in
… from call site
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/trivial.nix:966:7:
965| { # TODO: Should we add call-time "type" checking like built in?
966| __functor = self: f;
| ^
967| __functionArgs = args;
… while calling anonymous lambda
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/customisation.nix:136:17:
135| in
136| mirrorArgs (origArgs:
| ^
137| let
… while evaluating a branch condition
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/customisation.nix:148:7:
147| in
148| if isAttrs result then
| ^
149| result // {
… while calling the 'isAttrs' builtin
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/customisation.nix:148:10:
147| in
148| if isAttrs result then
| ^
149| result // {
… while calling a functor (an attribute set with a '__functor' attribute)
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/customisation.nix:138:16:
137| let
138| result = f origArgs;
| ^
139|
… from call site
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/trivial.nix:966:7:
965| { # TODO: Should we add call-time "type" checking like built in?
966| __functor = self: f;
| ^
967| __functionArgs = args;
… while calling anonymous lambda
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/customisation.nix:146:56:
145| # Change the result of the function call by applying g to it
146| overrideResult = g: makeOverridable (mirrorArgs (args: g (f args))) origArgs;
| ^
147| in
… from call site
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/customisation.nix:146:62:
145| # Change the result of the function call by applying g to it
146| overrideResult = g: makeOverridable (mirrorArgs (args: g (f args))) origArgs;
| ^
147| in
… while calling anonymous lambda
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/customisation.nix:153:29:
152| ${if result ? overrideAttrs then "overrideAttrs" else null} = fdrv:
153| overrideResult (x: x.overrideAttrs fdrv);
| ^
154| }
… from call site
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/customisation.nix:153:32:
152| ${if result ? overrideAttrs then "overrideAttrs" else null} = fdrv:
153| overrideResult (x: x.overrideAttrs fdrv);
| ^
154| }
… while calling anonymous lambda
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:100:8:
99| mkDerivationSimple
100| (f0:
| ^
101| let
… from call site
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:110:11:
109| in
110| makeDerivationExtensible (self: attrs // (if builtins.isFunction f0 || f0?__functor then f self attrs else f0)))
| ^
111| attrs;
… while calling 'makeDerivationExtensible'
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:77:30:
76| # Based off lib.makeExtensible, with modifications:
77| makeDerivationExtensible = rattrs:
| ^
78| let
… from call site
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:92:9:
91| finalPackage =
92| mkDerivationSimple overrideAttrs args;
| ^
93|
… while calling 'mkDerivationSimple'
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:516:1:
515| # * [package attributes]: https://nixos.org/manual/nix/stable/glossary#package-attribute-set
516| {
| ^
517|
… from call site
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:596:1:
595|
596| extendDerivation
| ^
597| validity.handled
… while calling 'extendDerivation'
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/customisation.nix:339:43:
338| */
339| extendDerivation = condition: passthru: drv:
| ^
340| let
… in the left operand of the update (//) operator
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/customisation.nix:364:20:
363| outputsList = map outputToAttrListElement outputs;
364| in commonAttrs // {
| ^
365| drvPath = assert condition; drv.drvPath;
… in the left operand of the update (//) operator
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/customisation.nix:343:25:
342|
343| commonAttrs = drv // (listToAttrs outputsList) //
| ^
344| ({ all = map (x: x.value) outputsList; }) // passthru;
… from call site
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:645:4:
644| passthru)
645| (derivation (derivationArg // optionalAttrs envIsExportable checkedEnv));
| ^
646|
… while calling anonymous lambda
at <nix/derivation-internal.nix>:30:1:
29| */
30| drvAttrs @ { outputs ? [ "out" ], ... }:
| ^
31|
… while calling the 'head' builtin
at <nix/derivation-internal.nix>:53:5:
52|
53| in (builtins.head outputsList).value
| ^
54|
… while calling the 'map' builtin
at <nix/derivation-internal.nix>:51:17:
50|
51| outputsList = map outputToAttrListElement outputs;
| ^
52|
… from call site
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:265:26:
264| # use attrNames, attrValues to ensure the two lists are sorted in the same way
265| outputs = [ "out" ] ++ lib.optionals (! __combine && __formatsOf == null) (builtins.attrNames nonEnvOutputs);
| ^
266| otherOutputs = lib.optionals (! __combine && __formatsOf == null) (builtins.attrValues nonEnvOutputs);
… while calling 'optionals'
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/lists.nix:820:5:
819| cond:
820| elems: if cond then elems else [];
| ^
821|
… while calling the 'attrNames' builtin
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:265:78:
264| # use attrNames, attrValues to ensure the two lists are sorted in the same way
265| outputs = [ "out" ] ++ lib.optionals (! __combine && __formatsOf == null) (builtins.attrNames nonEnvOutputs);
| ^
266| otherOutputs = lib.optionals (! __combine && __formatsOf == null) (builtins.attrValues nonEnvOutputs);
… from call site
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:190:19:
189| # other outputs
190| nonEnvOutputs = lib.genAttrs pkgList.nonEnvOutputs (outName: buildEnv' {
| ^
191| inherit name;
… while calling 'genAttrs'
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/attrsets.nix:1247:5:
1246| names:
1247| f:
| ^
1248| listToAttrs (map (n: nameValuePair n (f n)) names);
… while calling the 'listToAttrs' builtin
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/attrsets.nix:1248:5:
1247| f:
1248| listToAttrs (map (n: nameValuePair n (f n)) names);
| ^
1249|
… while calling the 'map' builtin
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/lib/attrsets.nix:1248:18:
1247| f:
1248| listToAttrs (map (n: nameValuePair n (f n)) names);
| ^
1249|
… while evaluating the attribute 'nonEnvOutputs'
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:112:5:
111| # outputs that do not become part of the environment
112| nonEnvOutputs = lib.subtractLists [ "out" "tex" "texdoc" "texsource" "tlpkg" ] otherOutputNames;
| ^
113|
… while calling the 'filter' builtin
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:112:21:
111| # outputs that do not become part of the environment
112| nonEnvOutputs = lib.subtractLists [ "out" "tex" "texdoc" "texsource" "tlpkg" ] otherOutputNames;
| ^
113|
… while calling the 'catAttrs' builtin
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:81:24:
80| specifiedOutputs = lib.groupBy (p: p.tlOutputName or p.outputName) specified.right;
81| otherOutputNames = builtins.catAttrs "key" (builtins.genericClosure {
| ^
82| startSet = map (key: { inherit key; }) (lib.concatLists (builtins.catAttrs "outputs" specified.wrong));
… while calling the 'genericClosure' builtin
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:81:49:
80| specifiedOutputs = lib.groupBy (p: p.tlOutputName or p.outputName) specified.right;
81| otherOutputNames = builtins.catAttrs "key" (builtins.genericClosure {
| ^
82| startSet = map (key: { inherit key; }) (lib.concatLists (builtins.catAttrs "outputs" specified.wrong));
… while calling the 'map' builtin
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:82:18:
81| otherOutputNames = builtins.catAttrs "key" (builtins.genericClosure {
82| startSet = map (key: { inherit key; }) (lib.concatLists (builtins.catAttrs "outputs" specified.wrong));
| ^
83| operator = _: [ ];
… while calling the 'concatLists' builtin
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:82:47:
81| otherOutputNames = builtins.catAttrs "key" (builtins.genericClosure {
82| startSet = map (key: { inherit key; }) (lib.concatLists (builtins.catAttrs "outputs" specified.wrong));
| ^
83| operator = _: [ ];
… while calling the 'catAttrs' builtin
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:82:64:
81| otherOutputNames = builtins.catAttrs "key" (builtins.genericClosure {
82| startSet = map (key: { inherit key; }) (lib.concatLists (builtins.catAttrs "outputs" specified.wrong));
| ^
83| operator = _: [ ];
… while calling the 'partition' builtin
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:79:17:
78| # group the specified outputs
79| specified = builtins.partition (p: p.outputSpecified or false) all;
| ^
80| specifiedOutputs = lib.groupBy (p: p.tlOutputName or p.outputName) specified.right;
… while calling the 'catAttrs' builtin
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:73:9:
72| if __fromCombineWrapper then requiredTeXPackages null else
73| builtins.catAttrs "p" (builtins.genericClosure {
| ^
74| startSet = map keySet runtime.right;
… while calling the 'genericClosure' builtin
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:73:32:
72| if __fromCombineWrapper then requiredTeXPackages null else
73| builtins.catAttrs "p" (builtins.genericClosure {
| ^
74| startSet = map keySet runtime.right;
… while calling the 'map' builtin
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:74:22:
73| builtins.catAttrs "p" (builtins.genericClosure {
74| startSet = map keySet runtime.right;
| ^
75| operator = p: map keySet p.tlDeps;
… while calling the 'partition' builtin
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:62:19:
61| packages = ensurePkgSets (requiredTeXPackages tl);
62| runtime = builtins.partition
| ^
63| (p: p.outputSpecified or false -> builtins.elem (p.tlOutputName or p.outputName) [ "out" "tex" "tlpkg" ])
… from call site
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:61:20:
60| let
61| packages = ensurePkgSets (requiredTeXPackages tl);
| ^
62| runtime = builtins.partition
… while calling 'ensurePkgSets'
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:52:19:
51| isOldPkgList = p: ! p.outputSpecified or false && p ? pkgs && builtins.all (p: p ? tlType) p.pkgs;
52| ensurePkgSets = ps: if ! __fromCombineWrapper && builtins.any isOldPkgList ps
| ^
53| then let oldPkgLists = builtins.partition isOldPkgList ps;
… while evaluating a branch condition
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:52:23:
51| isOldPkgList = p: ! p.outputSpecified or false && p ? pkgs && builtins.all (p: p ? tlType) p.pkgs;
52| ensurePkgSets = ps: if ! __fromCombineWrapper && builtins.any isOldPkgList ps
| ^
53| then let oldPkgLists = builtins.partition isOldPkgList ps;
… in the right operand of the AND (&&) operator
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:52:49:
51| isOldPkgList = p: ! p.outputSpecified or false && p ? pkgs && builtins.all (p: p ? tlType) p.pkgs;
52| ensurePkgSets = ps: if ! __fromCombineWrapper && builtins.any isOldPkgList ps
| ^
53| then let oldPkgLists = builtins.partition isOldPkgList ps;
… while calling the 'any' builtin
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:52:52:
51| isOldPkgList = p: ! p.outputSpecified or false && p ? pkgs && builtins.all (p: p ? tlType) p.pkgs;
52| ensurePkgSets = ps: if ! __fromCombineWrapper && builtins.any isOldPkgList ps
| ^
53| then let oldPkgLists = builtins.partition isOldPkgList ps;
… while calling 'isOldPkgList'
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:51:18:
50| # if necessary, convert old style { pkgs = [ ... ]; } packages to attribute sets
51| isOldPkgList = p: ! p.outputSpecified or false && p ? pkgs && builtins.all (p: p ? tlType) p.pkgs;
| ^
52| ensurePkgSets = ps: if ! __fromCombineWrapper && builtins.any isOldPkgList ps
… in the left operand of the AND (&&) operator
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:51:62:
50| # if necessary, convert old style { pkgs = [ ... ]; } packages to attribute sets
51| isOldPkgList = p: ! p.outputSpecified or false && p ? pkgs && builtins.all (p: p ? tlType) p.pkgs;
| ^
52| ensurePkgSets = ps: if ! __fromCombineWrapper && builtins.any isOldPkgList ps
… in the left operand of the AND (&&) operator
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:51:50:
50| # if necessary, convert old style { pkgs = [ ... ]; } packages to attribute sets
51| isOldPkgList = p: ! p.outputSpecified or false && p ? pkgs && builtins.all (p: p ? tlType) p.pkgs;
| ^
52| ensurePkgSets = ps: if ! __fromCombineWrapper && builtins.any isOldPkgList ps
… in the argument of the not operator
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/tools/typesetting/tex/texlive/build-tex-env.nix:51:23:
50| # if necessary, convert old style { pkgs = [ ... ]; } packages to attribute sets
51| isOldPkgList = p: ! p.outputSpecified or false && p ? pkgs && builtins.all (p: p ? tlType) p.pkgs;
| ^
52| ensurePkgSets = ps: if ! __fromCombineWrapper && builtins.any isOldPkgList ps
error: undefined variable 'ms'
at ~/.cache/nixpkgs-review/pr-351790-2/nixpkgs/pkgs/development/python-modules/manim/default.nix:158:7:
157| doublestroke
158| ms
| ^
159| setspac |
3b827ea
to
15c8392
Compare
@mirkolenz May be an unlucky state of master. I rebased again, hoping eval will pass now. |
Still got the same error with nixpkgs-review. But I agree that this is most likely some upstream issue not related to this PR since I was able to build it as part of my system config just fine. |
@GrahamcOfBorg build tests.texlive |
Great investigation of the issue 😄 I tried running |
If that's on NixOS, you may want to adjust number of parallel jobs and cores per job because the defaults may be to aggressive for massive builds: nix.settings = {
cores = 2;
max-jobs = 16;
}; (an example for a 32-core machine). |
Result of 26 packages marked as broken and skipped:
59 packages failed to build:
176 packages built:
|
Nothing TeX related, the actual failures are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. The osda package change is a bit worrying – I think we must either trust TeX Live and Debian and include it, or remove it altogether. I made other minor suggestions.
In the meanwhile, I am trying to run nixpkgs-review on Intel Darwin but it will take a while (and the Cambridge CTAN mirror keeps timing out... not a good time for rebuilding TeX Live in the UK!).
An additional discovery: texliveInfraOnly now depends on LuaTeX, because rungs is a Lua script. That kind of ruins the core/core-big distinction. Something to keep in mind for the next refactor.
PS: I am surprised OfBorg shows such a small rebuild. Good for us anyway, we can merge directly to master.
PPS: the first commit message says '2023' instead of '2024'!
"ftp://tug.ctan.org/pub/tex/historic/systems/texlive/${year}/texlive-${year}0313-source.tar.xz" | ||
]; | ||
hash = "sha256-OHiqDh7QMBwFOw4u5OmtmZxEE0X0iC55vdHI9M6eebk="; | ||
# FIXME revert to official tarballs for TeX-Live 2025 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you prefer to keep the upstream tarballs for the sake of copy-tarballs, we could also patch them with the GitHub diff. The diff is so small we could keep it directly in Nixpkgs (with a comment documenting its source, of course).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably okay to just use GitHub.
@@ -126,6 +126,11 @@ in lib.recursiveUpdate orig rec { | |||
"mtxrun.lua" = tl.context.tex + "/scripts/context/lua/mtxrun.lua"; | |||
}; | |||
|
|||
context-legacy.binlinks = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears they are not in TeX Live anymore, so that's fine.
XeTeX on Darwin is now compiled against Core Text/Cocoa, not fontconfig (possibly after rebasing against the latest master). This means the fontconfig file from #228196 does not work on macOS anymore, and the corresponding opentype-fonts test fails. We need to improve the wrapper somehow. |
A dirty hack is to patch |
This is going to be a breaking change for some workflows, right? We’re meant to be in the feature freeze period, but I guess holding off until 25.05 might be too long to go without a TeX Live update? |
There is not supposed to be a breaking change. However, this is meant to be merged after 25.05 branch-off. |
e3db7bc
to
0a7d474
Compare
According to https://new.ctan.org/pkg/ms it was split into other packages. According to https://github.com/3b1b/manim/blob/master/manimlib/tex_templates.yml only ragged2e is used (already depended on).
0a7d474
to
9cae926
Compare
Thank you! |
Resolves: #350953
Update to 2024 snapshot release
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.