Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.django-storages: Fix tests #351838

Merged
merged 3 commits into from
Oct 30, 2024
Merged

python3Packages.django-storages: Fix tests #351838

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7664e30
python3Packages.django-storages: Fix tests
onny Oct 28, 2024
a7c4257
python3Packages.django-storages: Add missing test dependency
onny Oct 28, 2024
05daae7
python3Packages.django-storages: Stylistic updates
onny Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions pkgs/development/python-modules/django-storages/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
pythonOlder,
rsa,
setuptools,
pynacl,
fetchpatch,
}:

buildPythonPackage rec {
Expand All @@ -31,9 +33,19 @@ buildPythonPackage rec {
hash = "sha256-nlM/XPot3auLzNsnHCVtog2WmiaibDRgbPOw9A5F9QI=";
};

nativeBuildInputs = [ setuptools ];
patches = [
# Add Moto 5 support
# https://github.com/jschneier/django-storages/pull/1464
(fetchpatch {
url = "https://github.com/jschneier/django-storages/commit/e1aedcf2d137f164101d31f2f430f1594eedd78c.patch";
hash = "sha256-jSb/uJ0RXvPsXl+WUAzAgDvJl9Y3ad2F30X1SbsCc04=";
name = "add_moto_5_support.patch";
})
];

build-system = [ setuptools ];

propagatedBuildInputs = [ django ];
dependencies = [ django ];

optional-dependencies = {
azure = [ azure-storage-blob ];
Expand All @@ -52,26 +64,24 @@ buildPythonPackage rec {
rsa
] ++ lib.flatten (builtins.attrValues optional-dependencies);

checkInputs = [ pynacl ];

pythonImportsCheck = [ "storages" ];

env.DJANGO_SETTINGS_MODULE = "tests.settings";

disabledTests = [
# AttributeError: 'str' object has no attribute 'universe_domain'
# https://github.com/jschneier/django-storages/issues/1463
"test_storage_save_gzip"
];

disabledTestPaths = [
# ImportError: cannot import name 'mock_s3' from 'moto'
"tests/test_s3.py"
];

meta = with lib; {
meta = {
description = "Collection of custom storage backends for Django";
changelog = "https://github.com/jschneier/django-storages/blob/${version}/CHANGELOG.rst";
downloadPage = "https://github.com/jschneier/django-storages/";
homepage = "https://django-storages.readthedocs.io";
license = licenses.bsd3;
maintainers = with maintainers; [ mmai ];
license = lib.licenses.bsd3;
maintainers = with lib.maintainers; [ mmai ];
};
}