Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tomlcpp: fix cross compilation #351896

Merged
merged 2 commits into from
Oct 29, 2024
Merged

tomlcpp: fix cross compilation #351896

merged 2 commits into from
Oct 29, 2024

Conversation

NickCao
Copy link
Member

@NickCao NickCao commented Oct 28, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

FliegendeWurst
FliegendeWurst approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkgsCross.aarch64-multiplatform.tomlcpp builds successfully

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 28, 2024
@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Oct 28, 2024
@ofborg ofborg bot requested a review from AndersonTorres October 28, 2024 16:51
@jwillikers
Copy link
Contributor

jwillikers commented Oct 28, 2024 •
edited
Loading

Confirmed this fixes cross-compiling.
Commands run:

nixpkgs-review pr 351896
nix build ./nixpkgs#pkgsCross.aarch64-multiplatform.tomlcpp

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Oct 28, 2024
@AndersonTorres
Copy link
Member

@ofborg build pkgsCross.aarch64-multiplatform.tomlcpp

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people and removed 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Oct 29, 2024
@NickCao NickCao merged commit 2f1fcc9 into NixOS:master Oct 29, 2024
39 of 41 checks passed
@NickCao NickCao deleted the tomlcpp branch October 29, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwillikers jwillikers jwillikers approved these changes

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

@AndersonTorres AndersonTorres AndersonTorres approved these changes

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NickCao @jwillikers @AndersonTorres @FliegendeWurst @wegank