luaPackages, vimPlugins: update on 2024-10-28 #351944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaneliman
commented
Oct 28, 2024
| postPatch = '' | ||
| substituteInPlace autoload/tabby/globals.vim --replace-fail \ | ||
| "let g:tabby_node_binary = get(g:, 'tabby_node_binary', 'node')" \ | ||
| "let g:tabby_node_binary = get(g:, 'tabby_node_binary', '${nodejs}/bin/node')" |
There was a problem hiding this comment.
Node functionality moved to tabby-agent. You can customize the init command through a custom function https://github.com/TabbyML/vim-tabby?tab=readme-ov-file#installation
ofborg
bot
requested review from
callumio,
natsukium,
mrcjkb and
PhotonQuantum
|
mrcjkb
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
Had to fix spectre cargoHash with updated plugin and remove vim-tabby patch with update.
Looks like the nvimRequireCheck for vim-tabby works fine without patching in #351321
tabby-agentis referenced as annpxcall https://github.com/TabbyML/vim-tabby/blob/b29c0681569fcc9857ff13835afec2dda9b8d90f/autoload/tabby/lsp.vim#L6 so technically should be fine to not hard link it for the build or do we want to wait on the package being available and linking it as a dependency?nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.