Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DISCLAIMER: I am aware that due to this PR reincluding an older version of gcc-arm-embedded (12.2.rel1) it won't be merged. I thought it still might be worthwhile to open it up as a reference for others and/or a place where to discuss possible workarounds.
blackmagic v2.0 should come out in a few months and it should build successfully with more recent versions of gcc-arm-embedded thanks to this.
Changes for v1.10.2 - https://github.com/blackmagic-debug/blackmagic/releases/tag/v1.10.2
Changes between v1.8.2 and v1.10.2 - blackmagic-debug/blackmagic@v1.8.2...v1.10.2
gcc-arm-embedded
v12.2.rel1 is repackaged and included because it's the most recent version where v1.10.2 still builds - blackmagic-debug/blackmagic#1978Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.