Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blackmagic: 1.8.2 -> 1.10.2 #352103

Closed
wants to merge 1 commit into from
Closed

Conversation

carlossless
Copy link
Contributor

@carlossless carlossless commented Oct 29, 2024

DISCLAIMER: I am aware that due to this PR reincluding an older version of gcc-arm-embedded (12.2.rel1) it won't be merged. I thought it still might be worthwhile to open it up as a reference for others and/or a place where to discuss possible workarounds.

blackmagic v2.0 should come out in a few months and it should build successfully with more recent versions of gcc-arm-embedded thanks to this.


Changes for v1.10.2 - https://github.com/blackmagic-debug/blackmagic/releases/tag/v1.10.2
Changes between v1.8.2 and v1.10.2 - blackmagic-debug/blackmagic@v1.8.2...v1.10.2

gcc-arm-embedded v12.2.rel1 is repackaged and included because it's the most recent version where v1.10.2 still builds - blackmagic-debug/blackmagic#1978

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Oct 29, 2024
@ofborg ofborg bot requested review from prtzl, sorki, prusnak and pjones October 29, 2024 17:41
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 29, 2024
@prusnak
Copy link
Member

prusnak commented Oct 29, 2024

can you try building with gcc-arm-embedded-11?

@carlossless
Copy link
Contributor Author

can you try building with gcc-arm-embedded-11?

I forgot to mention that I excluded gcc-arm-embedded-11 because it doesn't support aarch64-darwin which is one of the platforms that I needed blackmagic to work on. I'm guessing that it would succeed in building it on the platforms that it does support but have not tested it.

@carlossless
Copy link
Contributor Author

@prusnak I checked and I can confirm that this version builds with gcc-arm-embedded-11 on x86_64-linux

@prusnak
Copy link
Member

prusnak commented Oct 29, 2024

Reading the issue and comment blackmagic-debug/blackmagic#1978 (comment), I feel we should just close it for now and wait for blackmagic 2.0.x.

The PR will be useful for someone who wants to build 1.10x though, so thanks!

@prusnak prusnak closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants