Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raycast: 1.84.2 -> 1.84.8, move to pkgs/by-name #352202

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

DontEatOreo
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from stepbrobd and lovesegfault October 30, 2024 04:08
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 30, 2024
@stepbrobd
Copy link
Member

I think this might be a good time to migrate the package to by-name
What do you think?

@stepbrobd
Copy link
Member

@stepbrobd
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 352202


aarch64-darwin

✅ 1 package built:
  • raycast

@stepbrobd
Copy link
Member

Please change the PR title to reflect the update to 1.84.8
Everything else LGTM

@DontEatOreo DontEatOreo changed the title raycast: 1.84.2 -> 1.84.7 raycast: 1.84.2 -> 1.84.8, move to pkgs/by-name Oct 31, 2024
@stepbrobd stepbrobd added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Oct 31, 2024
@wegank wegank removed the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package label Oct 31, 2024
@ofborg ofborg bot requested a review from stepbrobd November 1, 2024 03:27
@wegank wegank added the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package label Nov 1, 2024
@sikmir sikmir merged commit 9a252d6 into NixOS:master Nov 1, 2024
35 of 36 checks passed
@DontEatOreo DontEatOreo deleted the update-raycast branch November 1, 2024 18:39
@DontEatOreo DontEatOreo added 6.topic: darwin Running or building packages on Darwin backport release-24.05 labels Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

Git push to origin failed for release-24.05 with exitcode 1

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants