Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signal-desktop: 7.29.0 -> 7.31.0; signal-desktop-beta: 7.30.0-beta.2-> 7.32.0-beta.1 #352218

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

Gliczy
Copy link
Member

@Gliczy Gliczy commented Oct 29, 2024

signalapp/Signal-Desktop@v7.29.0...v7.31.0
https://github.com/signalapp/Signal-Desktop/releases/tag/v7.30.0
https://github.com/signalapp/Signal-Desktop/releases/tag/v7.31.0

signalapp/Signal-Desktop@v7.30.0-beta.2...v7.32.0-beta.1
https://github.com/signalapp/Signal-Desktop/releases/tag/v7.31.0-beta.1
https://github.com/signalapp/Signal-Desktop/releases/tag/v7.32.0-beta.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 30, 2024
@Gliczy Gliczy changed the title signal-desktop: 7.29.0 -> 7.30.0; signal-desktop-beta: 7.30.0-beta.2-> 7.31.0-beta.1 signal-desktop: 7.29.0 -> 7.31.0; signal-desktop-beta: 7.30.0-beta.2-> 7.32.0-beta.1 Oct 30, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 31, 2024
@jopejoe1 jopejoe1 merged commit f00f17f into NixOS:master Oct 31, 2024
38 of 39 checks passed
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants