telegram-desktop: port derivation improvements from kotatogram-desktop

[ilya-fedin]

This backports various improvements made in kotatogram-desktop derivation, such as actualizing specified dependencies and rebases kotatogram-desktop on top of telegram-desktop override.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[ilya-fedin]

Result of nixpkgs-review pr 352359 run on x86_64-linux 1

1 package failed to build:

• materialgram

5 packages built:

• _64gram
• kotatogram-desktop
• kotatogram-desktop-with-webkit
• telegram-desktop
• telegram-desktop-with-webkit

[ilya-fedin]

@NickCao would be nice if you give a review, I want to get this sooner to start working on rebasing telegram and kotatogram to the new macOS SDK handling before branch off so 24.11 includes all the features currently commented in macos.patch.

[NickCao]

Wow I thought of making webkitgtk optional for a long time, thanks for doing that!

[NickCao]

kotatogram-desktop build is failing on ofborg.

[ilya-fedin]

Yeah, it fails on master since staging-next got merged...

[ilya-fedin]

Should build now

[NickCao]

@ofborg build telegram-desktop

[NickCao]

@ofborg build kotatogram-desktop

[NickCao]

Also: I'd intend to merge this after 24.11 branch off.

[ilya-fedin]

but why? 🤔

[NickCao]

but why? 🤔

Because this is very much a breaking change? (Well I might not even able to convince myself on this one, since webkitgtk integration has been broken from time to time)

[ilya-fedin]

Ok, added a toggle to build without webkitgtk so that just kotatogram can continue to use the wrapper

[ilya-fedin]

Result of nixpkgs-review pr 352359 run on x86_64-linux 1

1 package failed to build:

• materialgram

4 packages built:

• _64gram
• kotatogram-desktop
• kotatogram-desktop-with-webkit
• telegram-desktop

[NickCao]

diff LGTM, materialgram already failing on master.

[ilya-fedin]

LIBGL_ALWAYS_SOFTWARE=1 WEBKIT_DISABLE_DMABUF_RENDERER=1 QT_QPA_PLATFORM=xcb nix run .#telegram-desktop

Perhaps I need first two env vars due to mixing master's mesa with unstable system

[NickCao]

Tested basic functionality.

[ilya-fedin]

@clot27 btw, I have contacted 64gram developer, you should be able to get rid of the patch and cmake flags in your override soon

[ilya-fedin]

@NickCao is there still any sense to port the webkit wrapper to telegram--desktop or is the withWebKitGTK build option enough?

[NickCao]

@NickCao is there still any sense to port the webkit wrapper to telegram--desktop or is the withWebKitGTK build option enough?

There still is, I'd say most of the users can't care less about webkit and making that optional can be beneficial.

[ilya-fedin]

I mean you can now add something like that to all-packages.nix:

  telegram-desktop-without-webkitgtk = (telegram-desktop.override {
    withWebKitGTK = false;
  }).overrideAttrs(oldAttrs: {
    meta = oldAttrs.meta // { platforms = lib.platforms.linux };
  });

And the only (practical) difference to the wrapper will be that Hydra will build telegram-desktop two times for Linux. idk how big telegram-desktop is for Hydra, maybe there's no practical need in the additional wrapper and that's enough.

[NickCao]

telegram-desktop is certainly on the medium-large side, thus I'm in favor of the wrapper approach, just not that satisfied with the current implementation.

[ilya-fedin]

ok, here's it: #353243