nixos/ebusd: fix device access #352743
Merged
nixos/ebusd: fix device access #352743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
Birdy2014
force-pushed
the
ebusd-fix-devices
branch
from
abb7849 to
f17608d
Compare
FliegendeWurst
approved these changes
Dec 8, 2024
|
This should also be backported to 24.11. Do I need to do anything for that? |
I added the label, it will be backported once merged. (You can add labels on your own if you add yourself to the maintainer list.) |
wegank
added
12.approvals: 1
Birdy2014
force-pushed
the
ebusd-fix-devices
branch
from
f17608d to
e2f3298
Compare
wegank
removed
the
12.approvals: 1
|
Please fix the merge conflict. For some reason the file was reformatted as part of #322537 even though it was updated in this recent PR. |
Birdy2014
force-pushed
the
ebusd-fix-devices
branch
from
e2f3298 to
e983d9f
Compare
|
I think you dropped the PrivateDevices change accidentally. |
Birdy2014
force-pushed
the
ebusd-fix-devices
branch
from
e983d9f to
0c1feac
Compare
FliegendeWurst
approved these changes
Dec 11, 2024
This comment was marked as resolved.
This comment was marked as resolved.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
services.ebusd.deviceis set to a local device like/dev/ttyACM0, ebusd will fail with the errordevice invalid. This is because the module disallows all device access usingPrivateDeviceswhen a device is specified, instead of allowing device access.I only tested this change with an adapter that is connected via USB, but this shouldn't change the behavior of adapters connected over the network.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.