Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neovim: remove uneffective substituteInPlace patches #352855

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Nov 1, 2024

Things done

Those substituteInPlace have no effect and are not needed anymore.
This PR simply removes them.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python 6.topic: haskell 6.topic: qt/kde 8.has: documentation This PR adds or changes documentation 6.topic: rust 6.topic: ruby 6.topic: vim 6.topic: stdenv Standard environment 6.topic: lib The Nixpkgs function library 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: flutter labels Nov 1, 2024
@GaetanLepage GaetanLepage changed the base branch from master to staging November 1, 2024 12:22
@github-actions github-actions bot removed 6.topic: python 6.topic: haskell 6.topic: qt/kde 8.has: documentation This PR adds or changes documentation 6.topic: rust 6.topic: ruby 6.topic: vim 6.topic: stdenv Standard environment 6.topic: lib The Nixpkgs function library 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: flutter labels Nov 1, 2024
@GaetanLepage GaetanLepage requested a review from vcunat November 1, 2024 12:22
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux-stdenv This PR causes stdenv to rebuild 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ labels Nov 1, 2024
@GaetanLepage GaetanLepage requested a review from teto November 1, 2024 21:42
@teto teto merged commit 507c5dd into NixOS:staging Nov 1, 2024
55 of 58 checks passed
@GaetanLepage GaetanLepage deleted the neovim-clean branch November 1, 2024 22:02
@ofborg ofborg bot removed 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux-stdenv This PR causes stdenv to rebuild labels Nov 1, 2024
@ofborg ofborg bot requested review from rvolosatovs and manveru November 1, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants