Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{ares,bsnes-hd,higan}: update #353102

Merged
merged 10 commits into from
Dec 10, 2024
Merged

Conversation

AndersonTorres
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@AndersonTorres AndersonTorres force-pushed the migrate-bsnes-emulators branch from e997ded to 5c5c8b8 Compare November 2, 2024 14:30
@ofborg ofborg bot requested review from gridbugs and Madouura November 3, 2024 01:12
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 3, 2024
@AndersonTorres AndersonTorres force-pushed the migrate-bsnes-emulators branch from 5c5c8b8 to cce338c Compare November 3, 2024 03:06
@AndersonTorres AndersonTorres force-pushed the migrate-bsnes-emulators branch 3 times, most recently from fb81ca5 to 34b8d58 Compare November 3, 2024 16:05
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 4, 2024
@AndersonTorres AndersonTorres force-pushed the migrate-bsnes-emulators branch from 34b8d58 to b57f1c1 Compare November 7, 2024 02:25
@AndersonTorres AndersonTorres changed the title Migrate bsnes emulators {ares,bsnes-hd,higan}: update Nov 7, 2024
@AndersonTorres AndersonTorres marked this pull request as ready for review November 7, 2024 02:26
@AndersonTorres AndersonTorres force-pushed the migrate-bsnes-emulators branch from b57f1c1 to 2aed32a Compare November 7, 2024 02:29
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 10, 2024
@AndersonTorres AndersonTorres force-pushed the migrate-bsnes-emulators branch 2 times, most recently from 5b2c680 to 4c41860 Compare November 15, 2024 00:40
@AndersonTorres AndersonTorres removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 15, 2024
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4870

@AndersonTorres AndersonTorres force-pushed the migrate-bsnes-emulators branch from 4c41860 to ecaa6df Compare December 9, 2024 23:05
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4940

@lucasew
Copy link
Contributor

lucasew commented Dec 9, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 353102


x86_64-linux

✅ 2 packages built:
  • bsnes-hd
  • higan

@thiagokokada thiagokokada merged commit 2f3930f into NixOS:master Dec 10, 2024
19 of 20 checks passed
@AndersonTorres AndersonTorres deleted the migrate-bsnes-emulators branch December 14, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants