Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiviewer-for-f1: 1.35.2 -> 1.36.1 #353104

Merged
merged 1 commit into from
Nov 24, 2024
Merged

multiviewer-for-f1: 1.35.2 -> 1.36.1 #353104

merged 1 commit into from
Nov 24, 2024

Conversation

florensie
Copy link
Contributor

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@florensie
Copy link
Contributor Author

@ofborg eval

@ofborg ofborg bot requested a review from babeuh November 3, 2024 23:46
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 3, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 10, 2024
@florensie florensie removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 23, 2024
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 353104

x86_64-linux

✅ 1 package built:
  • multiviewer-for-f1

aarch64-linux

x86_64-darwin

aarch64-darwin

GaetanLepage
GaetanLepage approved these changes Nov 23, 2024
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GaetanLepage GaetanLepage added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 23, 2024
babeuh
babeuh approved these changes Nov 23, 2024
View reviewed changes
Copy link
Contributor

@babeuh babeuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 24, 2024
@ofborg ofborg bot requested a review from babeuh November 24, 2024 08:31
@GaetanLepage GaetanLepage merged commit c9bcd0e into NixOS:master Nov 24, 2024
35 of 36 checks passed
@florensie florensie deleted the update-multiviewer branch November 24, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babeuh babeuh babeuh approved these changes

@GaetanLepage GaetanLepage GaetanLepage approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@florensie @GaetanLepage @babeuh @wegank