Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

caido: 0.42.0 -> 0.43.1 #353203

Merged
merged 1 commit into from
Nov 4, 2024
Merged

caido: 0.42.0 -> 0.43.1 #353203

merged 1 commit into from
Nov 4, 2024

Conversation

f8thl3ss
Copy link
Contributor

@f8thl3ss f8thl3ss commented Nov 2, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Nov 2, 2024
SigmaSquadron
SigmaSquadron reviewed Nov 2, 2024
View reviewed changes
Copy link
Contributor

@SigmaSquadron SigmaSquadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Nixpkgs! Please use rebases, not merges, to update your PR to the latest master. There should only be a single commit named caido: 0.42.0 -> 0.43.1.

@f8thl3ss
Copy link
Contributor Author

f8thl3ss commented Nov 2, 2024

Welcome to Nixpkgs! Please use rebases, not merges, to update your PR to the latest master. There should only be a single commit named caido: 0.42.0 -> 0.43.1.

Thank you! :)
I've updated the PR accordingly.

@ofborg ofborg bot requested review from D3vil0p3r and octodi November 3, 2024 13:28
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 3, 2024
@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 3, 2024
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 3, 2024
@Aleksanaa Aleksanaa merged commit 07b3bef into NixOS:master Nov 4, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigmaSquadron SigmaSquadron SigmaSquadron left review comments

@octodi octodi octodi approved these changes

@D3vil0p3r D3vil0p3r D3vil0p3r approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@f8thl3ss @D3vil0p3r @octodi @SigmaSquadron @wegank @Aleksanaa @NixOSInfra