nixos/galene: add turnAddress option and fix httpAddress #353421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
FliegendeWurst
approved these changes
Dec 6, 2024
wegank
added
the
12.approvals: 1
K900
reviewed
Jan 3, 2025
| @@ -145,6 +152,8 @@ in | |||
| WorkingDirectory = cfg.stateDir; | |||
| ExecStart = ''${cfg.package}/bin/galene \ | |||
| ${optionalString (cfg.insecure) "-insecure"} \ | |||
| -http ${cfg.httpAddress}:${cfg.httpPort} \ | |||
There was a problem hiding this comment.
Was this ever tested? Hint: no it fucking wasn't, httpPort is an int.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current NixOS Galene module is not using
services.galene.httpAddressandservices.galene.httpPort. It is also missing the TURN address setting, making the NixOS module unusable when dealing with network setup hiding the public IP to the machine.Things done
Add
services.galene.turnAddressand add missing-httpparameter in Galene command line.nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.