Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localsend: 1.15.4-unstable-2024-10-26 -> 1.16.1 #353481

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

aucub
Copy link
Contributor

@aucub aucub commented Nov 3, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from linsui November 5, 2024 00:14
@sikmir
Copy link
Member

sikmir commented Nov 6, 2024

1.16.1 is out

@sikmir
Copy link
Member

sikmir commented Nov 6, 2024

Should we continue making changes here

Yes, that's fine.

@aucub aucub changed the title localsend: 1.15.4-unstable-2024-10-26 -> 1.16.0 localsend: 1.15.4-unstable-2024-10-26 -> 1.16.1 Nov 6, 2024
@aucub aucub marked this pull request as draft November 8, 2024 15:48
@aucub aucub marked this pull request as ready for review November 9, 2024 02:17
Copy link
Contributor

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff lgtm; app launches and seems to work correctly. I'm having issues with getting my devices to talk to one another on my university's WiFi though, so I can't test file transfers ATM.

@ofborg ofborg bot requested a review from Pandapip1 November 9, 2024 10:08
@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 10, 2024
@aucub aucub mentioned this pull request Nov 10, 2024
12 tasks
@ofborg ofborg bot requested a review from Pandapip1 November 11, 2024 20:21
@wegank wegank removed 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 11, 2024
@Aleksanaa Aleksanaa merged commit 9d14072 into NixOS:master Nov 12, 2024
27 of 28 checks passed
@aucub aucub deleted the localsend branch November 12, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

localsend: goes black after sending a file
6 participants