Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librewolf: 131.0.3 -> 132.0.1 #353484

Merged
merged 1 commit into from
Nov 8, 2024
Merged

librewolf: 131.0.3 -> 132.0.1 #353484

merged 1 commit into from
Nov 8, 2024

Conversation

DominicWrege
Copy link
Contributor

@DominicWrege DominicWrege commented Nov 3, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

output:
result/bin/librewolf


Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 4, 2024
@DominicWrege
Copy link
Contributor Author

DominicWrege commented Nov 5, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 353484


x86_64-linux

✅ 2 packages built:
  • librewolf-unwrapped
  • librewolf-unwrapped.debug

@h7x4 h7x4 requested a review from squalus November 5, 2024 21:32
Copy link
Member

@h7x4 h7x4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested, works well 👍

@h7x4 h7x4 merged commit 03661d6 into NixOS:master Nov 8, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants