Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-chrome: 130.0.6723.69 -> 130.0.6723.92 #353488

Merged
merged 1 commit into from
Nov 4, 2024
Merged

google-chrome: 130.0.6723.69 -> 130.0.6723.92 #353488

merged 1 commit into from
Nov 4, 2024

Conversation

JohnRTitor
Copy link
Contributor

@JohnRTitor JohnRTitor commented Nov 3, 2024 •
edited
Loading

https://chromereleases.googleblog.com/2024/10/stable-channel-update-for-desktop_29.html

This update includes 2 security fixes.

CVEs:
CVE-2024-10487 CVE-2024-10488

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@JohnRTitor JohnRTitor requested a review from jnsgruk November 3, 2024 20:32
@JohnRTitor JohnRTitor added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-24.05 labels Nov 3, 2024
jnsgruk
jnsgruk reviewed Nov 3, 2024
View reviewed changes
Copy link
Member

@jnsgruk jnsgruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good, assuming eval passes 👍

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 4, 2024
@ofborg ofborg bot requested a review from jnsgruk November 4, 2024 10:23
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 4, 2024
@JohnRTitor
Copy link
Contributor Author

Finally after 13 hrs, Ofborg decided it should start eval. I feel like the intervals of Ofborg each eval run have increased quite a lot recently?

@JohnRTitor JohnRTitor merged commit 1bc74de into NixOS:master Nov 4, 2024
42 of 44 checks passed
@github-actions github-actions bot mentioned this pull request Nov 4, 2024
Merged
1 task
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnsgruk jnsgruk Awaiting requested review from jnsgruk

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnRTitor @jnsgruk @wegank