Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux_xanmod, linux_xanmod_latest: 2024-11-01 #353508

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

Shawn8901
Copy link
Contributor

@Shawn8901 Shawn8901 commented Nov 3, 2024

Upstream archived Github Repo so we need to switch to Gitlab as Source, the website did link to GitLab since a longer time anyways.
In addition i thought that applying nixfmt now might be a good idea, when not just bumping (but having a trivial change).


Still building Still needs testing but maybe someone already wants to cherry-pick or so.
lts variant lgtm

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: kernel The Linux kernel label Nov 3, 2024
@Shawn8901 Shawn8901 changed the title Update xanmod linux_xanmod, linux_xanmod_latest: 2024-11-01 Nov 3, 2024
@nyabinary
Copy link
Contributor

Should probably put formatting on a different commit :P

@Shawn8901
Copy link
Contributor Author

Shawn8901 commented Nov 3, 2024

Should probably put formatting on a different commit :P

i can do so if you think that fetchFromGithub to fetchFromGitLab should have a separat commit.
The bumps had been a separate commit already.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 501+ 10.rebuild-linux: 501-1000 labels Nov 4, 2024
@Shawn8901 Shawn8901 marked this pull request as ready for review November 4, 2024 21:10
@Shawn8901
Copy link
Contributor Author

Shawn8901 commented Nov 4, 2024

sorry needed half a day to fix all the issue on my machines from the last staging merge, lts now tested from my end and dont see any issues on that.

Copy link
Member

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posting from it

@Atemu Atemu merged commit 9e72de3 into NixOS:master Nov 5, 2024
59 of 60 checks passed
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-353508-to-release-24.05 origin/release-24.05
cd .worktree/backport-353508-to-release-24.05
git switch --create backport-353508-to-release-24.05
git cherry-pick -x daa7d3d93fb919a1716475a8ca60de999fcc0c95 9907a40a5796e17e65e344510ff9f2bcb9625290 1cb34222f9c425544494ed38408ee6db7c6a990a 8fe9056838242e1e5bdeb5d817e0208b72877cdf

@Atemu Atemu added 9.needs: port to stable A PR needs a backport to the stable release. 8.has: port to stable A PR already has a backport to the stable release. and removed backport release-24.05 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 5, 2024
@Atemu
Copy link
Member

Atemu commented Nov 5, 2024

#353899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: kernel The Linux kernel 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+ 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants