guix: fix build user takeover patch #353533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, unfortunately I don’t think I’m passing the vulnerability check: |
|
Never mind, I forgot to remove my original patches override (#353471) from my NixOS config, which was removing the fixes. Confirmed the check passes now. |
The preceding fix only applies one of two patches, which breaks builds: error: getting attributes of path `/gnu/store/<item>': No such file or directory The Debian package maintainer, Vagrant Cascadian, is a frequent Guix committer, so the Debian package is a suitable upstream patch source when Guix commits require backporting to the current release tarball. Fixes: 633a3b8 ("guix: build user takeover patch")
hpfr
force-pushed
the
fix/guix-user-takeover-vuln
branch
from
aec99f8 to
e3c99d6
Compare
cafkafk
reviewed
Nov 4, 2024
wegank
approved these changes
Nov 4, 2024
wegank
added
the
12.approvals: 1
|
@ofborg test guix |
|
Good idea. I think I left the box checked for maintainer modifications, so you should be able to apply it here if you like 👍
|
|
Successfully created backport PR for |
1 task
I'll follow up (hopefully), I think it's better to just get this fix merged first tbh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message
Please label for backport to 24.05!
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.