-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/conduwuit: init #353651
nixos/conduwuit: init #353651
Conversation
d6ec162
to
01d2f08
Compare
The option |
39284e2
to
658a62f
Compare
Maybe a release note should be added as well? Other than that it looks good to undraft? |
9c78297
to
5660296
Compare
I'm still trying to get the nixosTests to pass, currently getting:
Edit: The "connection refused" simply came from the tests running before conduwuit was listening. Still getting this error though:
|
8a1fbd5
to
2b01471
Compare
74ac045
to
5eac3e9
Compare
Tests are passing now 🎊 |
03e0111
to
887e1fe
Compare
887e1fe
to
fef2e5d
Compare
fef2e5d
to
ee4ff8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks for the effort :3
dfa6fa9
to
4f2084c
Compare
Done addressing all feedback, fixing the tests right now, then we're good to go. Edit: Tests are ready as well. |
4f2084c
to
d4bee27
Compare
d4bee27
to
f6c47f0
Compare
Resolved merge conflicts in release notes |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2147 |
3c65ad3
to
48f0651
Compare
48f0651
to
5161dce
Compare
As conduwuit deviates more and more from its conduit origins, it makes sense to give conduwuit its own module.
A custom module has been wished by upstream maintainers (@girlbossceo) as well as fellow nixpkgs maintainers (@nyabinary).
This allows us to cover breaking changes such as:
Also includes the conduwuit-specific(?) fix from #353634.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.