Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{cctools,ld64}: set Darwin team as maintainers #353710

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Nov 4, 2024

This is a critical part of the Darwin build infrastructure.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy emilazy requested a review from a team November 4, 2024 20:50
@m1dugh
Copy link
Contributor

m1dugh commented Nov 4, 2024

Shouldn't it be 2 commits rather ?

This is a critical part of the Darwin build infrastructure.
This is a critical part of the Darwin build infrastructure.
@emilazy
Copy link
Member Author

emilazy commented Nov 4, 2024

Sure; split.

Copy link
Contributor

@reckenrode reckenrode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emilazy emilazy merged commit 6cf3947 into NixOS:master Nov 4, 2024
10 of 11 checks passed
@emilazy emilazy deleted the push-puspwxpsuqsr branch November 4, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants