Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aribb25: fix darwin build #353728

Merged
merged 3 commits into from
Nov 5, 2024
Merged

aribb25: fix darwin build #353728

merged 3 commits into from
Nov 5, 2024

Conversation

khaneliman
Copy link
Contributor

@khaneliman khaneliman commented Nov 4, 2024

Things done

ZHF: #352882
https://hydra.nixos.org/build/276774754/nixlog/1

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@khaneliman khaneliman added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 4, 2024
@khaneliman khaneliman marked this pull request as draft November 5, 2024 01:37
@khaneliman khaneliman marked this pull request as ready for review November 5, 2024 01:50
@khaneliman
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 353728


x86_64-linux

✅ 1 package built:
  • aribb25

aarch64-linux

✅ 1 package built:
  • aribb25

x86_64-darwin

✅ 1 package built:
  • aribb25

aarch64-darwin

✅ 1 package built:
  • aribb25

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 5, 2024
@Aleksanaa Aleksanaa merged commit 0b64ddc into NixOS:master Nov 5, 2024
18 of 19 checks passed
@ofborg ofborg bot requested a review from midchildan November 5, 2024 11:41
@khaneliman khaneliman deleted the aribb25 branch November 6, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants